Repository navigation
fix(mgr): Fix empty comboOptions suggestions query - #746
Merged
Merged
Conversation
xPDO quoted select('DISTINCT value') as one identifier, so MySQL 1054
emptied comboOptions suggestions. Log errorInfo when execute fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
GET /api/mgr/options/suggestionsвсегда отдавал пустой список:select('DISTINCT value')xPDO превращал вSELECT `DISTINCT value`и MySQL отвечал 1054. Теперьescape('value')+distinct(), при ошибкеexecute()пишетсяerrorInfoв журнал.Тип изменений
Связанные Issues
Closes #745
Как это было протестировано?
composer ci:php/composer test,npm run lint:ci,composer stan/ GitHub Actions CI)Конфигурация тестирования:
fix/issue-745-option-suggestionsотbetaСкриншоты (если применимо)
не применимо
Чеклист
composer stan/ CI jobPHPStan)npm run lint:ciдля Vue)Дополнительные заметки
После merge имеет смысл вручную проверить подсказки comboOptions на форме товара (связка с #702).