Repository navigation
fix(snippets): msProducts — menuindex при sortby массивом - #743
Merged
Merged
Conversation
Fenom/PHP array sortby was cast to the string "Array", so effective per-category menuindex never ran. Normalize arrays to JSON first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Fenom и PHP могут передать в
msProductssortbyмассивом (['menuindex' => 'ASC']). Сниппет делал(string), получал"Array", и подстановка effective menuindex (#625 / #737) не срабатывала: каталог молча сортировался по родномуmenuindexтовара.Массив нормализуется в JSON (pdoTools это умеет), JOIN
msCategoryMemberи CASE включаются так же, как для строки/JSON.Тип изменений
Связанные Issues
Closes #740
Связано: #625 / #627, #736 / #737.
Как это было протестировано?
Smoke:
['menuindex' => 'ASC']≡ JSON{"menuindex":"ASC"};['menuindex' => 'DESC', 'pagetitle' => 'ASC']подставляет только ключ menuindex.composer ci:php/composer test,npm run lint:ci,composer stan/ GitHub Actions CI)Конфигурация тестирования:
fix/issue-740-sortby-arrayЧеклист
composer stan/ CI jobPHPStan)npm run lint:ciдля Vue)Дополнительные заметки
Array без
menuindexпо-прежнему может сломать блокsortbyOptions(TypeError наpreg_match) — так было и до фикса. Сmenuindexв массиве теперь уходит JSON-строка.