Features extending instance hooks

Is your suggested enhancement related to a problem? Please describe.

Modrinth doesn't give any documentation towards the hooks for instances. My test script fails with error code 2 with zero logging from within the Modrinth app itself, except for the toast telling me it failed with error code 2.

Describe the solution you'd like

Some documentation towards the hooks and environment variables (or command line args) provided by Modrinth for the instance to use. I have provided some example images from MultiMC for reference towards what I would like to be added to Modrinth.

Describe alternatives you've considered

I have attempted to create a script that tells me what environment variables and command line arguments are available, but fails with error code 2 with zero explanation from the Modrinth app. The script works perfectly fine outside of Modrinth, but refuses to run and exits with error code 2 when used as a hook.

Additional context

N/A, all screenshots and context have been included above.

That's usually because those environment variables might not be supported yet or have a different name than the other launchers.

I believe the hooks in the Modrinth App currently don't support any variables, they're basically just triggers for running commands. They probably can be made more powerful in the future

Fix version pages by non-members being broken (#952)

It seems that this feature request is already in the TODO list in code:

code/packages/app-lib/src/api/profile/mod.rs

Lines 780 to 802 in 0f2ddb4

    
           if let Some(hook) = pre_launch_hooks { 
        
               // TODO: hook parameters 
        
               let mut cmd = hook.split(' '); 
        
               if let Some(command) = cmd.next() { 
        
                   let full_path = path.get_full_path().await?; 
        
                   let result = Command::new(command) 
        
                       .args(&cmd.collect::<Vec<&str>>()) 
        
                       .current_dir(&full_path) 
        
                       .spawn() 
        
                       .map_err(|e| IOError::with_path(e, &full_path))? 
        
                       .wait() 
        
                       .await 
        
                       .map_err(IOError::from)?; 
        
                   if !result.success() { 
        
                       return Err(crate::ErrorKind::LauncherError(format!( 
        
                           "Non-zero exit code for pre-launch hook: {}", 
        
                           result.code().unwrap_or(-1) 
        
                       )) 
        
                       .as_error()); 
        
                   } 
        
               } 
        
           }

Fix subscriptions edge case (#952)

these were added in #5916

Navigation Menu

Repository navigation

Features extending instance hooks #952

Is your suggested enhancement related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if let Some(hook) = pre_launch_hooks {
	// TODO: hook parameters
	let mut cmd = hook.split(' ');
	if let Some(command) = cmd.next() {
	let full_path = path.get_full_path().await?;
	let result = Command::new(command)
	.args(&cmd.collect::<Vec<&str>>())
	.current_dir(&full_path)
	.spawn()
	.map_err(\|e\| IOError::with_path(e, &full_path))?
	.wait()
	.await
	.map_err(IOError::from)?;

	if !result.success() {
	return Err(crate::ErrorKind::LauncherError(format!(
	"Non-zero exit code for pre-launch hook: {}",
	result.code().unwrap_or(-1)
	))
	.as_error());
	}
	}
	}

Features extending instance hooks #952

Description

Is your suggested enhancement related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Activity

EchoEllet commented on Jun 24, 2024

Prospector commented on Jun 24, 2024

EchoEllet commented on Jul 6, 2024

Prospector commented on Aug 18, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions