Skip to content

update requirements - #9737

Merged
Jintao-Huang merged 2 commits into
modelscope:mainfrom
Jintao-Huang:update_requirements_0713
Jul 13, 2026
Merged

Jintao-Huang merged 2 commits into
modelscope:mainfrom
Jintao-Huang:update_requirements_0713

Conversation

@Jintao-Huang

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dependency requirements for mcore-bridge and megatron-core in requirements/megatron.txt, and removes the runtime version check for mcore-bridge in swift/megatron/init.py. The reviewer suggests keeping the runtime version check and updating it to >=1.5.0 to match the new requirements, along with restoring the necessary import of require_version.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread swift/megatron/init.py
Comment thread swift/megatron/init.py
@Jintao-Huang
Jintao-Huang merged commit 6c7d381 into modelscope:main Jul 13, 2026
2 of 3 checks passed
Jintao-Huang added a commit that referenced this pull request Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant