Skip to content

Resolved mcp_config still contains the full platform_overrides map #265

Open

Description

@aosmcleod

Summary

getMcpConfigForManifest returns a resolved mcp_config that still carries the entire platform_overrides map (including other platforms' commands/env). The runtime config handed to the host is meant to be the resolved config, not the full override map.

Mechanism

src/shared/config.ts:114-128 — result = { ...baseConfig } shallow-copies, then the override branch overwrites command/args/env, but never removes result.platform_overrides. The returned object retains the full block.

Reproduction (executed)

Base config with darwin + win32 overrides, resolved on darwin → output has the correct command but still includes platform_overrides: { darwin: …, win32: … }.

Suggested fix

Drop the field after resolving:

delete result.platform_overrides;

(or construct result from explicit fields instead of spreading the whole base config).

Environment: current main (70fe3b3).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions