Repository navigation
Fix conv2d OOB reads for partial output-channel tiles - #4653
Merged
Merged
Conversation
Contributor
Author
|
cheers! and thats fine. |
Contributor
Author
|
will this pr be looked at soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4630.
partial output-channel tiles could take the fast path and read past the end of the weights buffer.
removed the
BN != 8shortcut from the 2D, 3D, and small-channel loaders so partial tiles use the safe load path.Tested the issue repro with Metal shader validation on:
M=9601, O=32M=9601, O=48M=9601, O=96M=8192, O=32Added regression tests for partial output-channel tiles.
Tested on an M5 MacBook Air running macOS Golden Gate 27.
The 54 conv test failures also occur on
mainat3c40e8fwithout this change.