Skip to content

Fix mx.view misaligned offset #4585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zcbenz merged 4 commits into from
Oct 1, 2026
Merged

Fix mx.view misaligned offset #4585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce02855
Fix mx.view misaligned offset
michalk8 Sep 29, 2026
1e2c3fc
Update python/tests/test_ops.py
michalk8 Sep 30, 2026
93fabff
Merge branch 'main' into fix-view-misaligned-offset
michalk8 Sep 30, 2026
3e7f5e3
Merge branch 'main' into fix-view-misaligned-offset
zcbenz Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions mlx/backend/gpu/primitives.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,10 @@ void View::eval_gpu(const std::vector<array>& inputs, array& out) {
// - type size is the same
// - type size is smaller and the last axis is contiguous
// - the entire array is row contiguous
if (ibytes == obytes || (obytes < ibytes && in.strides().back() == 1) ||
in.flags().row_contiguous) {
// and the offset is a multiple of the output type size
if (in.offset() % obytes == 0 &&
(ibytes == obytes || (obytes < ibytes && in.strides().back() == 1) ||
in.flags().row_contiguous)) {
auto strides = in.strides();
for (int i = 0; i < static_cast<int>(strides.size()) - 1; ++i) {
strides[i] *= ibytes;
Expand Down
8 changes: 8 additions & 0 deletions python/tests/test_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4154,6 +4154,14 @@ def test_view(self):
a_out = out.view(mx.int32)
self.assertTrue(mx.array_equal(a_out, a, equal_nan=True))

# Byte offsets that are not a multiple of the new item size
a = mx.arange(64, dtype=mx.uint8)
a_np = np.arange(64, dtype=np.uint8)
for start in range(8):
out = a[start : start + 16].view(mx.int32)
expected = a_np[start : start + 16].view(np.int32)
self.assertTrue(np.array_equal(out + 0, expected)) # read in a kernel

def _hadamard(self, N):
# Matches scipy.linalg.hadamard
H = np.array([[1]], dtype=np.int64)
Expand Down
Loading