Repository navigation
Add tile op - #438
Merged
Merged
Add tile op#438
Conversation
angeloskath
requested changes
Jan 12, 2024
angeloskath
left a comment
angeloskath
left a comment
Member
There was a problem hiding this comment.
Thanks this looks very nice, it is almost exactly what I had in mind :-) .
I left a comment regarding simplification. I think it can be simplified even more which imho makes it much more understandable.
Also I think the case where len(reps) > arr.ndim is not handled properly. At least it is not tested.
angeloskath
requested changes
Jan 13, 2024
angeloskath
left a comment
angeloskath
left a comment
Member
There was a problem hiding this comment.
Sorry for the back and forth. It looks great and now matches numpy's functionality.
Given your latest change I think 4 lines are now unnecessary so remove them and then it is merged :-) .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds the tile op, continuation from #317. @angeloskath this approach simplifies the execution based on your suggestions. Only utilizing 3 ops (2 reshapes / 1 broadcast)
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes