Repository navigation
fix type cast error in item() for bfloat16 - #339
Merged
Merged
Conversation
awni
reviewed
Jan 2, 2024
Comment on lines
+105
to
+106
| x = mx.array(1, mx.bfloat16) | ||
| self.assertEqual(x.item(), 1.0) |
3 of 4 tasks
JayYun98
pushed a commit
to JayYun98/mlx
that referenced
this pull request
Jan 7, 2024
Co-authored-by: xuan <xuan@apple.com>
zcbenz
pushed a commit
to Ritabanm/mlx
that referenced
this pull request
Sep 30, 2026
Testing `clip` converts array elements to builtin types and uses exact equaity. Converting `out` from float32 to 64-bit builtin float incurs floating-point errors, and further exact equality testing fails. So use `math.isclose` instead. closes ml-exploregh-339
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
So previously for
item()forbfloat16is buggy... for example:Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes