Repository navigation
Improve repeat using broadcasting and reshape - #318
Merged
Merged
Conversation
Member
|
🤦 thanks for catching that! |
awni
approved these changes
Dec 30, 2023
JayYun98
pushed a commit
to JayYun98/mlx
that referenced
this pull request
Jan 7, 2024
zcbenz
pushed a commit
to Ritabanm/mlx
that referenced
this pull request
Sep 30, 2026
Silence NonInteractiveExampleWarning in test_unary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeat was unnecessarily using concatenation and launching
repeatskernel calls to do the repeat. This improves it by broadcast and reshape which maps to a single copy kernel launch regardless of the number of repeats.For
repeatsvalues of 100 it can be up to 20x faster on my M2 air. It is the same speed for repeats values of 2 across the 1st axis which would be the best case scenario for the concatenation implementation.