Skip to content

Abort causes TypeError: Cannot read properties of null (reading 'reusedSocket') #37

Open

Description

@YarnSaw

Minimal repro:

#! /usr/bin/env node
'use strict';

const http = require('http');
const XHR = require('xmlhttprequest-ssl').XMLHttpRequest;

process.on('uncaughtException', (e) => { console.log('UNCAUGHT', e); process.exitCode = 1; });
process.on('unhandledRejection', (e) => { console.log('UNHANDLED', e); process.exitCode = 1; });

const server = http.createServer((req, res) => {
  // never respond to requests - simulate slow server for the abort
});

server.listen(0, '127.0.0.1', () => {
  requestAndAbort();
});

function requestAndAbort() {
  const url = new URL(`http://127.0.0.1:${server.address().port}`);
  const xhr = new XHR();

  xhr.open('GET', url);
  xhr.send();

  setTimeout(() => {
    console.log('calling abort()');
    try { 
      xhr.abort()
    }
    catch (e) {
      console.log('abort() threw:', e)
    }
    setTimeout(() => { 
      server.close();
      server.closeAllConnections?.();
      process.exit();
    }, 500);
    
  }, 200);
}

Adding optional chaining to request in if (request.reusedSocket && error.code === 'ECONNRESET') appears to fix the problem without any side effects - ie if (request?.reusedSocket && error.code === 'ECONNRESET').

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions