Skip to content

[io] Encode a float crop (values in [0, 1]) like the same crop in uint8 in encode_crop - #2205

Merged
felixdittrich92 merged 1 commit into
mindee:mainfrom
RavSinghChandan:encode-crop-float-pages
Oct 30, 2026
Merged

felixdittrich92 merged 1 commit into
mindee:mainfrom
RavSinghChandan:encode-crop-float-pages

Conversation

@RavSinghChandan

Copy link
Copy Markdown
Contributor

The predictors take float pages with values in [0, 1], and keep them as the page image. encode_crop passed such a crop to cv2.imencode as is: OpenCV warned Unsupported depth image for selected encoder is fallbacked to CV_8U and wrote values of 0 and 1, so the figures of the embedded and referenced exports were black images.

A float crop is now scaled to uint8 first, so it gives the same image as the uint8 crop

@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.76%. Comparing base (50c2ef1) to head (49fad70).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2205      +/-   ##
==========================================
- Coverage   97.77%   97.76%   -0.01%     
==========================================
  Files         170      170              
  Lines       10980    10982       +2     
==========================================
+ Hits        10736    10737       +1     
- Misses        244      245       +1     
Flag Coverage Δ
unittests 97.76% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@felixdittrich92 felixdittrich92 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@felixdittrich92 felixdittrich92 self-assigned this Oct 30, 2026
@felixdittrich92 felixdittrich92 added type: enhancement Improvement module: io Related to doctr.io ext: tests Related to tests folder labels Oct 30, 2026
@felixdittrich92 felixdittrich92 added this to the 1.2.0 milestone Oct 30, 2026
@felixdittrich92
felixdittrich92 merged commit 0bc3d7c into mindee:main Oct 30, 2026
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ext: tests Related to tests folder module: io Related to doctr.io type: enhancement Improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants