Skip to content

Audit Mail shared directives for v3 wrappers - #3840

Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 2 commits into
powershell-v3from
ramsessanchez-mail-v3-migration
Open

Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 2 commits into
powershell-v3from
ramsessanchez-mail-v3-migration

Conversation

@ramsessanchez

@ramsessanchez Ramses Sanchez-Hernandez (ramsessanchez) commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

N/A

Changes proposed in this pull request

Mail's shared AutoRest directives need reviewed v3 coverage without duplicating behavior already provided by the wrapper generator's parity data. This audits only the three cmdlet directive groups in src/Mail/Mail.md, retaining the original directives as active legacy configuration.

  • Record exact HTTP method, path, and operation-ID evidence from the compatible v1.0 spec. Existing derived data already suppresses the exact folder-message content GET and renames the three replyAll and three createReplyAll actions; no redundant curated overrides are introduced. Module-specific regression coverage also pins ordinary reply actions and neighboring content routes.
  • Require v1.0 only. Beta is explicitly excluded because openApiDocs_KiotaCompat/beta/Mail.yml is missing, not because beta APIs are generally unsupported or the corresponding operations are proven absent. Each beta mapping declares excluded: true, an empty operations array, and explanatory notes, without absenceExpected or a legacy-spec fallback.
  • Ignore all directives in src/readme.graph.md and profile-specific readmes. Parameter aliases/transforms and schema/response directives remain deferred.

Commit boundaries: d33a22219f contains the migration/audit, annotations, evidence ledger, and tests. 8ece8353a1 contains the combined full v1.0 regeneration. Both are rebased onto powershell-v3 at 51d441eeb5, including merged #3837 and #3838. The real Kiota and cmdlet generation left client/cmdlet sources, generated projects, and dependency locks unchanged; the sole persisted generated-output change is the client lock's Kiota version metadata from 1.34.1 to 1.36.1. Repeating full generation after #3838 produced no additional content changes, so no extra generation commit was fabricated.

Post-merge evidence:

  • Get-WrapperDirectiveMigrationInventory.ps1 -Module Mail -FailOnUnresolved passes: all three shared directives are Mapped, with explicit missing-compatible-spec beta exclusions validated by merged Support reviewed shared-directive migration edge cases #3838.
  • Targeted Mail, derived-resolution, and curated-verb regression tests pass 42/42 after rebasing.
  • Full Build-WrapperModule.ps1 -Module Mail -ApiVersion v1.0 -Configuration Release -SpecRoot .\openApiDocs_KiotaCompat rerun succeeds in 18.2 seconds without skip/generate-only/no-collision switches, using isolated Kiota 1.36.1 and installed Authentication 2.41.0.
  • The freshly compiled module exports 146 cmdlets; all six migrated names, ordinary reply actions, the content suppression, and neighboring content commands are intact. All 132 direct operations match the existing parity oracle, with 14 dispatchers.
  • The pinned compatible spec blob remains 060600b783c8909e6cada593ed5313fa4793a67e. No beta generation or legacy fallback was attempted.

The original audit annotations record the prerequisite dependency present at review time. That historical limitation is now resolved by merged #3838; no strict-gate blocker remains. No shared generator/tooling patches are included in this module PR.

Other links

Record exact compatible operation evidence, preserve existing derived coverage, and distinguish excluded beta input from absent API operations. Add focused Mail regression coverage without duplicate overrides.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the full Release build against openApiDocs_KiotaCompat v1.0 with Kiota 1.36.1. Client and cmdlet sources, generated projects, and dependency locks are unchanged; only Kiota version metadata in the client lock changes. The compiled module exports 146 commands and all 132 direct operations match published parity.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant