Repository navigation
Audit Mail shared directives for v3 wrappers - #3840
Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 2 commits into
Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 2 commits into
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 2 commits into
Conversation
Record exact compatible operation evidence, preserve existing derived coverage, and distinguish excluded beta input from absent API operations. Add focused Mail regression coverage without duplicate overrides. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run the full Release build against openApiDocs_KiotaCompat v1.0 with Kiota 1.36.1. Client and cmdlet sources, generated projects, and dependency locks are unchanged; only Kiota version metadata in the client lock changes. The compiled module exports 146 commands and all 132 direct operations match published parity. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Ramses Sanchez-Hernandez (ramsessanchez)
marked this pull request as ready for review
October 22, 2026 00:36
Ramses Sanchez-Hernandez (ramsessanchez)
requested a review
from a team
as a code owner
October 22, 2026 00:36
Ramses Sanchez-Hernandez (ramsessanchez)
force-pushed
the
ramsessanchez-mail-v3-migration
branch
from
October 22, 2026 00:37
f7ed1ac to
8ece835
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
N/A
Changes proposed in this pull request
Mail's shared AutoRest directives need reviewed v3 coverage without duplicating behavior already provided by the wrapper generator's parity data. This audits only the three cmdlet directive groups in
src/Mail/Mail.md, retaining the original directives as active legacy configuration.replyAlland threecreateReplyAllactions; no redundant curated overrides are introduced. Module-specific regression coverage also pins ordinary reply actions and neighboring content routes.openApiDocs_KiotaCompat/beta/Mail.ymlis missing, not because beta APIs are generally unsupported or the corresponding operations are proven absent. Each beta mapping declaresexcluded: true, an empty operations array, and explanatory notes, withoutabsenceExpectedor a legacy-spec fallback.src/readme.graph.mdand profile-specific readmes. Parameter aliases/transforms and schema/response directives remain deferred.Commit boundaries:
d33a22219fcontains the migration/audit, annotations, evidence ledger, and tests.8ece8353a1contains the combined full v1.0 regeneration. Both are rebased ontopowershell-v3at51d441eeb5, including merged #3837 and #3838. The real Kiota and cmdlet generation left client/cmdlet sources, generated projects, and dependency locks unchanged; the sole persisted generated-output change is the client lock's Kiota version metadata from 1.34.1 to 1.36.1. Repeating full generation after #3838 produced no additional content changes, so no extra generation commit was fabricated.Post-merge evidence:
Get-WrapperDirectiveMigrationInventory.ps1 -Module Mail -FailOnUnresolvedpasses: all three shared directives areMapped, with explicit missing-compatible-spec beta exclusions validated by merged Support reviewed shared-directive migration edge cases #3838.Build-WrapperModule.ps1 -Module Mail -ApiVersion v1.0 -Configuration Release -SpecRoot .\openApiDocs_KiotaCompatrerun succeeds in 18.2 seconds without skip/generate-only/no-collision switches, using isolated Kiota 1.36.1 and installed Authentication 2.41.0.060600b783c8909e6cada593ed5313fa4793a67e. No beta generation or legacy fallback was attempted.The original audit annotations record the prerequisite dependency present at review time. That historical limitation is now resolved by merged #3838; no strict-gate blocker remains. No shared generator/tooling patches are included in this module PR.
Other links