Repository navigation
Save op columns to json files. - #312
Merged
Merged
Conversation
Chao Zhang (chinazhangchao)
changed the title
Chao Zhang (chinazhangchao)
requested review from
Qiong Wu (qiowu) (DingmaomaoBJTU) and
vortex-captain
April 13, 2026 01:08
Qiong Wu (qiowu) (DingmaomaoBJTU)
left a comment
Qiong Wu (qiowu) (DingmaomaoBJTU)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR! The column metadata pre-loading is a nice optimization. I have one potential bug and a few suggestions — see inline comments.
Chao Zhang (chinazhangchao)
requested review from
Qiong Wu (qiowu) (DingmaomaoBJTU) and
Zhipeng Wang (timenick)
April 13, 2026 02:05
vortex-captain
approved these changes
Apr 13, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.