Repository navigation
Support external weights in CG Input IR - #1522
Merged
Zhenchao Ni (zhenchaoni) merged 1 commit intoNov 6, 2026
Merged
Conversation
Qiong Wu (qiowu) (DingmaomaoBJTU)
approved these changes
Nov 6, 2026
Qiong Wu (qiowu) (DingmaomaoBJTU)
left a comment
Qiong Wu (qiowu) (DingmaomaoBJTU)
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed both Runtime load call sites and the external-resource preparation helper. No blocking findings. Local validation: all 92 runtime-session tests passed. Additional checks with mocked Foundry metadata covered bytecode selection, an exact-end slice, rejection of negative/out-of-file ranges, empty external-tensor metadata, and the ONNX/Output IR bypasses. Read-only views retain their shared mmap as intended. CI checks are green. Actual IX parsing and native Runtime external-resource lifetime/inference were not exercised locally.
Zhenchao Ni (zhenchaoni)
deleted the
private/zhenni/cgir_external_weights
branch
November 6, 2026 07:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support IX-exported external CGIR weights in Windows ML Runtime inference and compilation.
Use IX's tensor metadata to bind read-only memory-mapped resources automatically. Resource preparation stays outside inference timing. No export/build changes or manual resource mapping are required.
Usage
Keep the generated
model.mlir.dataalongsidemodel.mlir; weights are loaded automatically.