Repository navigation
Honor NPZ calibration input in static quantization - #1507
Draft
ssss141414 wants to merge 2 commits into
Draft
ssss141414 wants to merge 2 commits into
ssss141414 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InputDataDatasetcalibration_load_pathin static QDQ quantization before task-specific or random fallbackWhy
Static quantization accepted
calibration_load_pathin configuration but did not consume it. For the Wav2Vec2 optimization demo this silently selected random calibration, which was not representative of speech and failed the declared tensor-quality gate.Reproduction
The immutable end-to-end replay is in
demo/deliveries/v2/bundle: runrepro.ps1to verify hashes, WinML 0.4.0, and exact PR HEAD828fce6dea347360338307a6d863d13edb78a5efbefore rebuilding.repro-run.ps1is the underlying clean public-CLI replay.Validation
git diff --check origin/main...HEADpassed.windowsmlaccess violation whiletests/unit/session/conftest.pyinitialized the EP catalog. This is outside the changed calibration path. The two packaging failures observed before termination were independently rerun with the corporate mirror and passed.validated; champion SHA-256316802bd3f3912fa1df24c12181555a98834c1a1efaf998c700e59171f789a92.Measured result
On Snapdragon X QNN NPU, burst mode and graph finalization mode 3:
Complexity review
Fallback seven-rung review (Ponytail unavailable): Lean already. Ship. Net removable lines: 0. The implementation reuses existing loading, validation, dtype conversion, batching, and sample slicing; the new class is only the ORT
CalibrationDataReaderadapter required forget_nextandrewind. No dependency, option, or model-specific path was added.Risks
Rollback
Revert commits
828fce6dea347360338307a6d863d13edb78a5efandc8c8ad2a5183159a45e48dc5ae1ab200b9fcb453. Static quantization will return to task-specific/random calibration fallback, and callers relying oncalibration_load_pathwill again have that configuration ignored.Review state
NO_MATERIAL_OMISSIONREADY_FOR_CHECK_INwith no blocking findings828fce6dea347360338307a6d863d13edb78a5efThis change was discovered while using the auto-optimize skill on
audeering/wav2vec2-large-robust-12-ft-emotion-msp-dim.