Skip to content

Make VSTest repo buildable in VMR non-source-build - #4920

Merged
Jakub Jareš (nohwnd) merged 7 commits into
mainfrom
MakeVSTestBuildInVMR
Mar 6, 2024
Merged

Make VSTest repo buildable in VMR non-source-build#4920
Jakub Jareš (nohwnd) merged 7 commits into
mainfrom
MakeVSTestBuildInVMR

Conversation

@ViktorHofer

@ViktorHofer Viktor Hofer (ViktorHofer) commented Mar 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Contributes to dotnet/source-build#4030

  • DotNetBuildFromSource -> DotNetBuildSourceOnly
  • DotNetBuildFromSourceFlavor -> DotNetBuildOrchestrator
  • SourceBuild.props -> DotNetBuild.props
  • AfterSolutionBuild.targets: Add a condition as runtime download currently doesn't work inside the VMR

mmitche
Matt Mitchell (mmitche) reviewed Mar 6, 2024
View reviewed changes
Comment thread Directory.Build.targets Resolved
mmitche
Matt Mitchell (mmitche) reviewed Mar 6, 2024
View reviewed changes
Comment thread Directory.Build.targets Resolved
mmitche
Matt Mitchell (mmitche) approved these changes Mar 6, 2024
View reviewed changes

ghost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes otherwise look good. Should at least be straight compatible in source-build mode.

Viktor Hofer and others added 6 commits March 6, 2024 16:41
Viktor Hofer Matt Mitchell
Update Directory.Build.targets
3d88c28 
Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
Viktor Hofer Matt Mitchell
Update Directory.Build.targets
4826d45 
Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
Viktor Hofer Matt Mitchell
Update src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.…
d2976cc 
…csproj

Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
Viktor Hofer Matt Mitchell
Update src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.…
86079ed 
…csproj

Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
Viktor Hofer Matt Mitchell
Update src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.…
d380ae7 
…CLI.csproj

Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
Viktor Hofer Matt Mitchell
Update src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.…
ae2e78d 
…CLI.csproj

Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
@nohwnd
Jakub Jareš (nohwnd) enabled auto-merge (squash) March 6, 2024 16:55
@nohwnd
Jakub Jareš (nohwnd) merged commit 82c581f into main Mar 6, 2024
@nohwnd
Jakub Jareš (nohwnd) deleted the MakeVSTestBuildInVMR branch March 6, 2024 17:25
@renovate renovate Bot mentioned this pull request Feb 10, 2025
Merged
1 task
This was referenced Oct 26, 2026
Open
Open
Open
Open
Open
Open
Merged
Open
Merged
Closed
Open
Open
Open
Open
Closed
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Closed
Open
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nohwnd Jakub Jareš (nohwnd) nohwnd approved these changes
@Evangelink Amaury Levé (Evangelink) Awaiting requested review from Evangelink Evangelink is a code owner
+1 more reviewer
@mmitche Matt Mitchell (mmitche) mmitche approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ViktorHofer @nohwnd @mmitche