Repository navigation
Agents - improve multi-file diff editor actions - #343368
Merged
Ladislau Szomoru (lszomoru) merged 3 commits intoOct 22, 2026
Merged
Ladislau Szomoru (lszomoru) merged 3 commits into
Ladislau Szomoru (lszomoru) merged 3 commits into
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Benjamin Christopher Simmonds (@benibenj)Matched files:
|
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
3 open issues
ImportingActiveMultiDiffEditorHasFileListContextfrom `workbench/contrib/multiDiffEditor/browser/… · New The PR description focuses on relocating “Word Wrap” and “Diff View” actions, but this change also… · New The keybinding placeholder is concatenated immediately after “toolbar” (\"toolbar{0}\"), which… · New
What changed in this PR
Moves Sessions “Word Wrap” and “Diff View” actions from the editor header overflow into the tab row overflow, and adjusts command/context handling so the actions behave correctly when invoked from editor title menus.
Changes:
- Relocates “Word Wrap” and “Diff View” menu contributions to the editor title (tab row) overflow groups.
- Updates command handlers to extract
IEditorCommandsContextfrom variadic args (accounting for resource-first invocation). - Extends Sessions/Agents window behavior and tests around multi-diff file list controls and Toggle Details behavior.
| File | Description |
|---|---|
| src/vs/workbench/contrib/multiDiffEditor/test/browser/actions.test.ts | Updates assertions to validate refined preconditions for multi-diff file list submenu actions. |
| src/vs/workbench/contrib/multiDiffEditor/browser/multiDiffEditorAccessibilityHelp.ts | Adjusts accessibility help text for Sessions/Agents window behavior. |
| src/vs/workbench/contrib/multiDiffEditor/browser/actions.ts | Exports submenu/context expressions so Sessions UI can reuse them; broadens action preconditions. |
| src/vs/sessions/contrib/layout/test/browser/desktopLayoutController.test.ts | Adds coverage ensuring “Toggle Details” targets multi-diff file list when appropriate. |
| src/vs/sessions/contrib/layout/browser/desktop/desktopExistingSessionStrategy.ts | Modifies Toggle Details toggled state + run behavior to toggle multi-diff file list based on group context. |
| src/vs/sessions/contrib/changes/test/browser/changesViewActions.test.ts | Updates menu-location assertions and adds test for Files View & Position availability. |
| src/vs/sessions/contrib/changes/browser/changesViewActions.ts | Moves Sessions Diff View / Word Wrap contributions to editor title overflow; adds Files View & Position submenu. |
| src/vs/sessions/DESKTOP.md | Documents updated Toggle Details semantics for multi-diff file list. |
Review effort: Lite
Benjamin Christopher Simmonds (benibenj)
previously approved these changes
Oct 21, 2026
…dule Address review feedback: the Agents window imported the file list context expression and submenu id from the multi diff editor actions module, which registers menus and actions at load time. Move them to the common module and share the editor id constant with MultiDiffEditor.ID. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
roblourens
approved these changes
Oct 21, 2026
roblourens
approved these changes
Oct 22, 2026
Dileep Yavanmandha (dileepyavan)
approved these changes
Oct 22, 2026
…e-details-action-multi-file-diff
Ladislau Szomoru (lszomoru)
marked this pull request as draft
October 22, 2026 06:13
Ladislau Szomoru (lszomoru)
marked this pull request as ready for review
October 22, 2026 06:14
Ladislau Szomoru (lszomoru)
deleted the
lszomoru/agents/toggle-details-action-multi-file-diff
branch
October 22, 2026 06:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This pull request moves the Word Wrap and Diff View actions from the header's "..." menu to the tab row's "..." menu for better accessibility and usability.
Changes made:
Word Wrap Action:
1_diffgroup, alongside the existing Word Wrap for text files.Diff View Submenu:
Context Handling:
Tests:
changesViewActions.test.tsto verify the new locations of the Diff View and Word Wrap actions, ensuring they are no longer present in the header menu.Additional Notes: