Repository navigation
chat: run implicit context selection debounce tests in virtual time - #342249
Merged
Alexandru Dima (alexdima) merged 1 commit intoOct 17, 2026
Merged
Conversation
Both tests slept a real 510ms per step to get past the 500ms selection debounce. Run them in virtual time; the ordering they check is unchanged. Each test drops from ~1.5s to a few ms. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow test-only changes preserve the tested ordering and assertions, with no unresolved findings.
No open issues 🎉
What changed in this PR
Speeds up two chat implicit-context debounce tests using the existing virtual-time helper.
Changes:
- Wraps both tests in
runWithFakedTimers. - Preserves assertions, timing intervals, and production behavior.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/browser/attachments/chatImplicitContext.test.ts | Replaces real-time waits with virtual scheduling in two tests. |
Review effort: Balanced
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
Alexandru Dima (alexdima)
marked this pull request as ready for review
October 17, 2026 16:12
Alexandru Dima (alexdima)
enabled auto-merge (squash)
October 17, 2026 16:13
Ladislau Szomoru (lszomoru)
approved these changes
Oct 17, 2026
Alexandru Dima (alexdima)
deleted the
agents/test-perf-implicit-context-debounce
branch
October 17, 2026 16:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc Henning Dieterichs (@hediet)
Both tests slept a real 510ms per step to get past the 500ms selection debounce. Run them in virtual time; the ordering they check is unchanged.
Each test drops from ~1.5s to a few ms.
Part of a series that speeds up unit tests waiting on real time, found from the slow tests in the Linux Electron unit test job. Each change is a separate PR so it can be reverted on its own. Test files only; no assertions changed.
How to test
Results on macOS, with only this commit applied on top of 832a728:
./scripts/test.sh --run src/vs/workbench/contrib/chat/test/browser/attachments/chatImplicitContext.test.ts: 11 passing (2s)