Repository navigation
agentHost: run SSH and WSL relay replacement tests in virtual time - #342247
Merged
Alexandru Dima (alexdima) merged 1 commit intoOct 17, 2026
Merged
Conversation
The relay replacement tests only use mocks but waited out the protocol client's 1s real-time reconnect backoff. Run them in virtual time. Each test drops from ~1s to a few ms. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped timer changes preserve test synchronization and assertions, with no unresolved findings.
No open issues 🎉
What changed in this PR
Speeds up mocked Agent Host relay replacement tests by advancing reconnect backoff in virtual time.
Changes:
- Wraps two SSH tests and one WSL test in
runWithFakedTimers. - Preserves existing assertions and production code.
| File | Description |
|---|---|
| src/vs/platform/agentHost/test/electron-browser/wslRemoteAgentHostService.test.ts | Converts the late replacement relay test to virtual time. |
| src/vs/platform/agentHost/test/electron-browser/sshRemoteAgentHostService.test.ts | Converts late replacement and independent renderer lease tests to virtual time. |
Review effort: Balanced
Alexandru Dima (alexdima)
marked this pull request as ready for review
October 17, 2026 09:39
Alexandru Dima (alexdima)
enabled auto-merge (squash)
October 17, 2026 09:40
Ladislau Szomoru (lszomoru)
approved these changes
Oct 17, 2026
Alexandru Dima (alexdima)
deleted the
agents/test-perf-remote-relay-backoff
branch
October 17, 2026 10:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fyi Connor Peet (@connor4312)
The relay replacement tests only use mocks but waited out the protocol client's 1s real-time reconnect backoff. Run them in virtual time.
Each test drops from ~1s to a few ms.
Part of a series that speeds up unit tests waiting on real time, found from the slow tests in the Linux Electron unit test job. Each change is a separate PR so it can be reverted on its own. Test files only; no assertions changed.
How to test
Results on macOS, with only this commit applied on top of 832a728:
./scripts/test.sh --run src/vs/platform/agentHost/test/electron-browser/sshRemoteAgentHostService.test.ts --run src/vs/platform/agentHost/test/electron-browser/wslRemoteAgentHostService.test.ts: 82 passing (30ms)