Repository navigation
ci: run type-aware checks after compile bundling - #342114
Closed
Bryan Chen (bryanchen-d) wants to merge 1 commit into
Closed
Bryan Chen (bryanchen-d) wants to merge 1 commit into
Bryan Chen (bryanchen-d) wants to merge 1 commit into
Conversation
TEMP: includes a memory sampler and a baseline job for measurement; both are removed before review. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Temporary draft instrumentation remains, and the revised scheduling needs memory validation on the CI runner before final approval.
0 open findings
What changed in this PR
Reduces overlapping memory demand in Code OSS CI by moving type-aware checks after compilation and bundling, following #339153 and addressing #341818.
Changes:
- Separates compilation/hygiene from ESLint and type-aware checks while retaining existing checks.
- Adds temporary memory sampling and a baseline job to compare scheduling.
| File | Description |
|---|---|
.github/workflows/pr.yml |
Splits check groups and adds temporary baseline measurement. |
.github/tmp-mem-sampler.sh |
Records peak observed runner memory and command duration while preserving exit status. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
Author
|
Closing: the measurements below show the split doesn't help. It lowers the worst peak by only 0.8 GB and makes the job 27 s slower. Details are on #341818.
|
Bryan Chen (bryanchen-d)
deleted the
bryanchen-d/split-compile-hygiene-memory
branch
October 16, 2026 18:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #339153 for #341818. Splits the remaining seven-way Compile & Hygiene step into two steps, so the checks that each build a TypeScript program no longer overlap with
core-ci's minified bundling.core-ci,hygiene,vscode-dts-compile-check,test-build-scriptseslint,tsec-compile-check,define-class-fields-check,valid-layers-checkDraft: this PR temporarily contains a memory sampler and a baseline job that measures the current layout. Both are removed before review.