Repository navigation
chat: grow migration tree rows to fit MCP warnings - #341853
Merged
Vritant Bhardwaj (vritant24) merged 2 commits intoOct 15, 2026
Merged
Conversation
The migration tree delegate reported dynamic heights for rows with migration changes, but the tree was created without supportDynamicHeights, so rows stayed fixed at 68px. MCP servers with several warnings were clipped, hiding the server name and later warnings. Enable dynamic heights and lay out with the container width so wrapped warnings are re-measured on resize. Add component fixtures for an MCP server with several warnings at regular and narrow widths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Vritant Bhardwaj (vritant24)
requested review from
Hawk Ticehurst (hawkticehurst)
and
a balanced review from Copilot
October 15, 2026 19:44
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes follow the existing tree measurement contract, with regression fixtures and no unresolved findings.
0 open findings
What changed in this PR
Fixes clipped MCP migration warnings in the Chat Customizations migration tree.
Changes:
- Enables dynamic row heights for migration warnings.
- Passes container width to tree layout so wrapped warnings are remeasured on resize.
- Adds wide and narrow fixtures with five MCP warnings.
| File | Description |
|---|---|
| src/vs/workbench/test/browser/componentFixtures/sessions/customizationMigrationDashboard.fixture.ts | Adds warning-heavy fixtures at 860px and 360px widths. |
| src/vs/workbench/contrib/chat/browser/aiCustomization/customizationMigrationDashboard.ts | Enables dynamic heights and width-aware layout. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Screenshot ChangesBase: Added (2)
|
Hawk Ticehurst (hawkticehurst)
approved these changes
Oct 15, 2026
Vritant Bhardwaj (vritant24)
deleted the
agents/fix-migration-tree-view-warnings
branch
October 15, 2026 21:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCP servers with several migration warnings overflow their row in the Migrations tree, which clips the server name and the later warnings.
Cause
MigrationTreeDelegate.hasDynamicHeightalready returnstruefor rows with migration changes. However, theWorkbenchObjectTreewas created withoutsupportDynamicHeights, so the list ignored the delegate and kept every row at the fixed 68px height.Changes
supportDynamicHeightson the migration tree so rows with warnings are measured and grow to fit their content. Rows without warnings keep their fixed height.MigrationsMcpWarningsandMigrationsMcpWarningsNarrowcomponent fixtures for an MCP server with five warnings at 860px and 360px widths.Screenshots
Fixture
MigrationsMcpWarningswith a GitHub MCP server that has five migration warnings (Dark theme).Narrow layout (
MigrationsMcpWarningsNarrow, 360px):How to test
Open the Chat Customizations → Migrations page with a workspace
.vscode/mcp.jsonserver that triggers several warnings, for example inputs, config variables, OAuth,gallery, anddev. The row should show the server name and every warning without clipping or overlapping the next row. You can also view thechat/aiCustomizations/customizationMigrationDashboard/MigrationsMcpWarnings*fixtures in the component explorer.Validation
./scripts/test.sh --run src/vs/workbench/contrib/chat/test/browser/aiCustomization/customizationMigrationDashboard.test.ts: passed (12 tests)npm run eslint -- <changed files>: passedMigrations,MigrationsNarrow,MigrationsMcpWarnings, andMigrationsMcpWarningsNarrow(Dark): passed (5/5 stable)supportDynamicHeightsreproduced the clipped row in the new fixture, which confirms the option is what fixes it.