Repository navigation
sessions: stabilize bottom panel tab geometry - #341849
Merged
Merged
Conversation
Make the Agents panel title-border override more specific than the shared panel rule so stylesheet load order cannot change tab and action heights. Update the regression expectations to the intended full-height geometry.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Benjamin Christopher Simmonds (@benibenj)Matched files:
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow specificity fix and matching regression assertions address the reported failure with no unresolved findings.
0 open findings
What changed in this PR
Stabilizes Agents window bottom-panel tab geometry after #341806 by removing stylesheet load-order dependence.
Changes:
- Increases specificity of the Agents-only title-border override.
- Updates regression expectations for full-height tabs and centered actions.
| File | Description |
|---|---|
| src/vs/sessions/test/browser/parts/panelPart.test.ts | Updates height, centering, and indicator expectations. |
| src/vs/sessions/browser/parts/media/panelPart.css | Scopes the border override to the Agents workbench with higher specificity. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
Hawk Ticehurst (hawkticehurst)
approved these changes
Oct 15, 2026
Ross Wollman (rwoll)
enabled auto-merge
October 15, 2026 20:00
Ross Wollman (rwoll)
deleted the
sandy081/fix-panel-test-css-isolation
branch
October 15, 2026 20:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the full-suite regression introduced by #341806 and reported in #341806 (comment).
The Agents panel rule that removes the classic top title border had the same specificity as the shared panel rule that adds it. As a result, stylesheet load order changed the available content height between focused and full-suite runs. This makes the Agents override explicitly more specific and updates the regression expectations to the intended full-height, vertically centered geometry.
Validation
npm run build-fast -- --client-only— passed../scripts/test.sh --run src/vs/sessions/test/browser/parts/panelPart.test.ts --reporter dot— passed, 5 tests../scripts/test.sh --run src/vs/sessions/test/browser/parts/panelPart.test.ts --run src/vs/sessions/contrib/terminal/test/browser/terminalTabsStyles.test.ts --reporter dot— passed, 14 tests after rebasing onto currentmain.npm run stylelint -- src/vs/sessions/browser/parts/media/panelPart.css— passed.npm run eslint -- src/vs/sessions/test/browser/parts/panelPart.test.ts— passed.npm run typecheck-client— passed.git diff --check— passed../scripts/test.sh --reporter dot— the affected panel test passed in the full-suite CSS loading environment; 55,880 tests passed and 23 unrelated tests failed because local home paths resolved to/Users/sandy081instead of their expected/home/...fixtures.