Repository navigation
Recommend connectors below the new chat composer - #341844
Merged
Hawk Ticehurst (hawkticehurst) merged 4 commits intoOct 15, 2026
Merged
Hawk Ticehurst (hawkticehurst) merged 4 commits into
Hawk Ticehurst (hawkticehurst) merged 4 commits into
Conversation
Hawk Ticehurst (hawkticehurst)
marked this pull request as draft
October 15, 2026 19:00
Hawk Ticehurst (hawkticehurst)
marked this pull request as ready for review
October 15, 2026 19:02
Hawk Ticehurst (hawkticehurst)
changed the title
Contributor
Screenshot ChangesBase: Changed (23)
|
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/MigrationsNarrow/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/MigrationsBackground/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionExperimentalComposer/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionExperimentalComposerBackground/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionOptionsExpanded/Light
| Before | After |
|---|---|
|
|
sessions/chat/newWidget/newChatWidget/NewSessionOptionsCollapsed/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionOptionsIconRail/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionOptionsAnimated/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionOptionsExpandedNarrow/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionPromptPickers/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionVoicePickerSpacing/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionPromptPickersNarrow/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionPromptPickersCompact/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionPhoneAttachedContext/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionPhoneWelcomePhrase/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionPhoneSettingsDisabled/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionPhoneUnifiedWorkspacePicker/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionPhoneExperimentalComposer/Light
| Before | After |
|---|---|
 |
 |
sessions/blockedSessionsList/BlockedSessionsList_OneApproval/Light
| Before | After |
|---|---|
 |
 |
sessions/blockedSessionsList/BlockedSessionsList_TwoApprovals/Light
| Before | After |
|---|---|
 |
 |
sessions/blockedSessionsList/BlockedSessionsList_FiveApprovals/Light
| Before | After |
|---|---|
 |
 |
sessions/blockedSessionsList/BlockedSessionsList_FixCIAndApproval/Light
| Before | After |
|---|---|
 |
 |
Added (13)
sessions/chat/newWidget/newChatWidget/ConnectorRecommendationsBefore/Light
sessions/chat/newWidget/newChatWidget/ConnectorRecommendations/Light
sessions/chat/newWidget/newChatWidget/ConnectorRecommendationsNarrow/Light
sessions/chat/newWidget/newChatWidget/ConnectorRecommendationsOneDismissed/Light
sessions/chat/newWidget/newChatWidget/ConnectorRecommendationsTwoDismissed/Light
sessions/chat/newWidget/newChatWidget/ConnectorRecommendationsFallbackIcons/Light
sessions/chat/newWidget/newChatWidget/ConnectorRecommendationsBackground/Light
sessions/chat/newWidget/newChatWidget/ConnectorRecommendationsWithNotices/Light
sessions/chat/newWidget/newChatWidget/ConnectorRecommendationsShortAfterLayoutToggle/Light
sessions/chat/newWidget/newChatWidget/ConnectorRecommendationsFocused/Light
sessions/chat/newWidget/newChatWidget/ConnectorRecommendationsPhone/Light
sessions/chat/newWidget/newChatWidget/ConnectorRecommendationsPhoneWithNotices/Light
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverCopilotConnectorDetail/Light
Dmitriy Vasyura (dmitrivMS)
previously approved these changes
Oct 15, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Stale navigation, desktop clipping, and inconsistent focus and notice ordering remain unresolved.
4 open findings
What changed in this PR
Adds product-configured connector recommendations to the Agents window’s new-chat composer.
Changes:
- Adds experiment-controlled cards with direct connector navigation and independent dismissal.
- Groups recommendations, tips, and migration notices into a shared support area.
- Adds accessibility help, behavior tests, and visual fixtures.
| File | Description |
|---|---|
| src/vs/workbench/test/browser/componentFixtures/sessions/aiCustomizationManagementEditor.fixture.ts | Adds direct connector-detail fixture. |
| src/vs/workbench/contrib/chat/common/aiCustomizationWorkspaceService.ts | Extends marketplace navigation targets. |
| src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationManagementEditor.ts | Adds connector lookup and detail navigation. |
| src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationManagement.contribution.ts | Handles connector and search targets. |
| src/vs/sessions/contrib/chat/test/browser/sessionsChatAccessibilityHelp.test.ts | Tests recommendation help visibility. |
| src/vs/sessions/contrib/chat/test/browser/newChatWidget.fixture.ts | Adds recommendation and layout fixtures. |
| src/vs/sessions/contrib/chat/test/browser/newChatConnectorRecommendations.test.ts | Tests visibility, navigation, dismissal, and icons. |
| src/vs/sessions/contrib/chat/common/constants.ts | Defines recommendation setting identifier. |
| src/vs/sessions/contrib/chat/browser/sessionsChatAccessibilityHelp.ts | Documents recommendation interactions. |
| src/vs/sessions/contrib/chat/browser/newChatWidget.ts | Integrates cards and shared support stack. |
| src/vs/sessions/contrib/chat/browser/newChatConnectorRecommendations.ts | Implements recommendation cards. |
| src/vs/sessions/contrib/chat/browser/media/newChatMigrationNotice.css | Aligns migration notice styling. |
| src/vs/sessions/contrib/chat/browser/media/newChatConnectorRecommendations.css | Styles cards and focus indicators. |
| src/vs/sessions/contrib/chat/browser/media/chatWidget.css | Positions support surfaces across layouts. |
| src/vs/sessions/contrib/chat/browser/chat.contribution.ts | Registers experimental setting. |
| src/vs/base/common/product.ts | Defines recommendation metadata. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Hawk Ticehurst (hawkticehurst)
force-pushed
the
hawkticehurst/issue-341452-connector-recommendations
branch
from
October 15, 2026 19:44
8c5a3f9 to
75de1bb
Compare
Hawk Ticehurst (hawkticehurst)
enabled auto-merge (squash)
October 15, 2026 19:56
Add product-configured Linear, Notion, and WorkIQ recommendation cards behind an experiment, including direct connector-detail navigation, responsive and accessible dismissal behavior, and targeted fixture coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep support surfaces scrollable in short panes, preserve dynamic ordering, advance dismissal focus, and cancel superseded connector detail navigation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Verify a short desktop pane keeps the composer visible while recommendations and notices use a scrollable region after repeated layout toggles. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Hawk Ticehurst (hawkticehurst)
force-pushed
the
hawkticehurst/issue-341452-connector-recommendations
branch
from
October 15, 2026 20:14
75de1bb to
1482aa7
Compare
Anthony Kim (anthonykim1)
approved these changes
Oct 15, 2026
Hawk Ticehurst (hawkticehurst)
deleted the
hawkticehurst/issue-341452-connector-recommendations
branch
October 15, 2026 20:54
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #341452
Companion product metadata: microsoft/vscode-distro#1467
The Agents window did not help users discover useful connectors from the new-chat composer. This adds compact, independently dismissible Linear, Notion, and WorkIQ recommendation cards that use product-configured metadata and open the selected connector's detail page directly.
Implementation
sessions.chat.experimental.connectorRecommendationssetting and records its experiment trigger before control/treatment divergence.product.connectorRecommendations.Screenshots
Dark theme
Light theme
High Contrast Dark
High Contrast Light
Direct connector navigation
Activation steps
Independent dismissal
Phone coexistence
Keyboard focus and missing product images
Cards with tips and migrations
Constrained and custom-background layouts
Short desktop pane after review feedback
Validation
npm run compile-client— Passed with 0 errors..\scripts\test.bat --reporter dot --run src/vs/sessions/contrib/chat/test/browser/newChatConnectorRecommendations.test.ts --run src/vs/sessions/contrib/chat/test/browser/sessionsChatAccessibilityHelp.test.ts— Passed, 49 tests.npm run eslint -- src/vs/base/common/product.ts src/vs/sessions/contrib/chat/browser/chat.contribution.ts src/vs/sessions/contrib/chat/browser/newChatConnectorRecommendations.ts src/vs/sessions/contrib/chat/browser/newChatWidget.ts src/vs/sessions/contrib/chat/browser/sessionsChatAccessibilityHelp.ts src/vs/sessions/contrib/chat/common/constants.ts src/vs/sessions/contrib/chat/test/browser/newChatConnectorRecommendations.test.ts src/vs/sessions/contrib/chat/test/browser/newChatWidget.fixture.ts src/vs/sessions/contrib/chat/test/browser/sessionsChatAccessibilityHelp.test.ts src/vs/workbench/contrib/chat/common/aiCustomizationWorkspaceService.ts src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationManagement.contribution.ts src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationManagementEditor.ts src/vs/workbench/test/browser/componentFixtures/sessions/aiCustomizationManagementEditor.fixture.ts— Passed for all 13 requested files.npm run stylelint -- src/vs/sessions/contrib/chat/browser/media/chatWidget.css src/vs/sessions/contrib/chat/browser/media/newChatConnectorRecommendations.css src/vs/sessions/contrib/chat/browser/media/newChatMigrationNotice.css— Passed for all 3 requested files.ConnectorRecommendations|DiscoverCopilotConnector— Passed, 32 of 32 fixtures rendered without errors.npm run typecheck-client— Passed.npm run valid-layers-check— Passed.