Repository navigation
Agents - more cleaup for the branch picker default value - #341766
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Worktree isolation regressions and incomplete test migration remain unresolved.
4 open findings
What changed in this PR
Refines Agents branch-picker defaults using structured Git HEAD and branch information.
Changes:
- Adds
getHEADto the Git service. - Updates isolation eligibility and default-branch selection.
- Adjusts Git-service mocks and branch-resolution tests.
| File | Description |
|---|---|
| src/vs/platform/agentHost/test/node/shared/worktreeIsolation.test.ts | Updates branch defaults and detached-HEAD expectations. |
| src/vs/platform/agentHost/test/node/copilotGitProject.test.ts | Adds getHEAD mock. |
| src/vs/platform/agentHost/test/node/copilotAgent.test.ts | Adds getHEAD mock. |
| src/vs/platform/agentHost/test/node/agentService.test.ts | Updates Git-service interface stubs. |
| src/vs/platform/agentHost/test/node/agentHostPullRequestOperationHandler.test.ts | Adds getHEAD mock. |
| src/vs/platform/agentHost/test/node/agentHostGitService.test.ts | Tests attached and detached HEAD resolution. |
| src/vs/platform/agentHost/test/node/agentHostDiscardChangesOperationHandler.test.ts | Adds getHEAD mock. |
| src/vs/platform/agentHost/test/node/agentHostCommitOperationHandler.test.ts | Adds getHEAD mock. |
| src/vs/platform/agentHost/test/common/sessionTestHelpers.ts | Extends the shared Git-service stub. |
| src/vs/platform/agentHost/node/shared/worktreeIsolation.ts | Uses structured branches for isolation configuration. |
| src/vs/platform/agentHost/node/agentHostGitService.ts | Implements HEAD resolution. |
| src/vs/platform/agentHost/common/agentHostGitService.ts | Declares the getHEAD contract. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Aiday Marlen Kyzy (aiday-mar)
previously approved these changes
Oct 15, 2026
Sandeep Somavarapu (sandy081)
approved these changes
Oct 15, 2026
Anthony Kim (anthonykim1)
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.