Repository navigation
Support presentation preferences for Markdown embedded editors - #341742
Merged
Henning Dieterichs (hediet) merged 5 commits intoOct 15, 2026
Merged
Conversation
Forward validated resizable, full-width and full-view preferences from static contributions and exported providers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Undefined resolve-result preferences erase contribution defaults instead of inheriting them.
1 open finding
What changed in this PR
Adds presentation preferences for contributed Markdown embedded editors. Runtime controls remain dependent on the companion package release and dependency update.
Changes:
- Validates and forwards presentation preferences through provider descriptors and RPC.
- Includes preferences in equality checks.
- Documents the contract and adds contribution/schema tests.
| File | Description |
|---|---|
| extensions/markdown-language-features/src/test/markdownEditorProvider.test.ts | Tests contribution preference validation. |
| extensions/markdown-language-features/src/preview/markdownEditorProvider.ts | Validates, merges, forwards, and compares preferences. |
| extensions/markdown-language-features/src/preview/markdownEditorProtocol.ts | Adds the presentation RPC schema. |
| extensions/markdown-language-features/src/markdownExtensions.ts | Reads and compares contribution preferences. |
| extensions/markdown-language-features/scripts/codeBlockEditorPresentation.test.mts | Tests schema acceptance and rejection. |
| extensions/markdown-language-features/schemas/package.schema.json | Defines contribution presentation options. |
| extensions/markdown-language-features/CONTRIBUTING.md | Documents presentation preferences and precedence. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Preserve contributed presentation defaults when providers return undefined optional fields. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Henning Dieterichs (hediet)
marked this pull request as ready for review
October 15, 2026 15:02
Contributor
|
Base:
|
roblourens
previously approved these changes
Oct 15, 2026
Keep the published Markdown editor 0.0.2-130 dependency while incorporating main's clipboard-media changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Henning Dieterichs (hediet)
enabled auto-merge
October 15, 2026 18:21
Dmitriy Vasyura (dmitrivMS)
approved these changes
Oct 15, 2026
Henning Dieterichs (hediet)
deleted the
hediet/markdown-editor-presentation
branch
October 15, 2026 21:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose generic presentation preferences for contributed Markdown code-block editors and consume their published runtime implementation.
Companion package implementation: https://github.com/microsoft/vscode-packages/pull/366 (merged and published). The publication blocker is resolved; no local dependency link is committed. This is generic extension integration and contains no Team Tools or VS Code Apps implementation.
Validation
Validated against a worktree-local npm installation of @vscode/markdown-editor@0.0.2-130 (not the development checkout):
The previous Windows / Electron-Unit run had 25,079 passing tests and one unrelated teardown failure: session-storage compatibility cleanup received EBUSY unlinking agent-host.db. A new CI run is triggered by the dependency/fix commit.