Repository navigation
sessions: preserve remote tags in recent folders - #341654
Merged
Merged
Conversation
Fixes #338415 by passing remote-aware folder labels when opening a session in the editor. Resolve helper services through a fresh accessor and cover remote labels and multi-folder tunnel handoffs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change preserves existing fallback behavior, has targeted regression coverage, and has no identified blockers.
0 open findings
What changed in this PR
Preserves remote host tags when Agents window sessions are opened in the editor, addressing missing tags in Windows recent folders.
Changes:
- Passes remote-aware workspace labels when opening folders.
- Resolves services through a fresh accessor.
- Expands regression coverage for supported remotes and Windows multi-folder labels.
Windows taskbar behavior was not manually verified.
| File | Description |
|---|---|
| src/vs/sessions/test/electron-browser/vscodeActions.test.ts | Tests remote labels and updates service invocation. |
| src/vs/sessions/electron-browser/actions/vscodeActions.ts | Preserves remote labels during editor handoff. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
roblourens
marked this pull request as ready for review
October 15, 2026 16:16
roblourens
enabled auto-merge (squash)
October 15, 2026 16:16
Vritant Bhardwaj (vritant24)
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #338415.
Preserve the Agents window's remote-aware workspace label when opening a session in the editor, so Windows recent-folder entries retain the remote host tag. Local folders and unsupported-remote fallback behavior are unchanged.
Refactor
openSessionInVSCodeto resolve its services from a fresh accessor supplied byIInstantiationService.invokeFunction. Tests use the same invocation path and cover SSH, tunnels, WSL, Dev Containers, and Windows multi-folder labels.Validation
npm run typecheck-client— passed.npm run build-fast -- --client-only— passed../scripts/test.sh --run src/vs/sessions/test/electron-browser/vscodeActions.test.ts --run src/vs/sessions/test/browser/resolveRemoteAuthority.test.ts --reporter dot— passed, 44 tests.npm run eslint -- src/vs/sessions/electron-browser/actions/vscodeActions.ts src/vs/sessions/test/electron-browser/vscodeActions.test.ts— passed.git diff --check— passed.Current-head CI passed: Code OSS, CodeQL, Component Fixtures, Monaco Editor checks, Telemetry, and chat-lib tests. Windows unit tests passed after retrying an unrelated saved-chat continuation assertion; Linux smoke tests passed after two suite-level timeouts. No code changes were needed for those retries. Copilot review reported no findings.
The Windows taskbar UI was not manually exercised on macOS. To verify on Windows, open a remote tunnel session in the Agents window, choose Open in Editor, close the editor window, and confirm the taskbar recent-folder entry includes the remote host tag.
(Written by Copilot)