Repository navigation
Agents window: align terminal instance list styling - #341568
Merged
Lee Murray (mrleemurray) merged 1 commit intoOct 15, 2026
Merged
Lee Murray (mrleemurray) merged 1 commit into
Lee Murray (mrleemurray) merged 1 commit into
Conversation
Match the editor window's inset, rounded terminal rows in default and compact density, while preserving the Agents panel background and drop-target highlighting. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped styling changes have regression coverage and no identified blocking issues.
0 open findings
What changed in this PR
Aligns the Agents window terminal instance list with the editor’s Modern UI styling.
Changes:
- Adds inset, rounded rows for default and compact density.
- Matches the panel background while preserving drop-target highlighting.
- Adds computed-style coverage for themes, density, and icon-only mode.
No actionable findings remain. Live visual and keyboard-interaction testing was not recorded.
| File | Description |
|---|---|
| src/vs/sessions/contrib/terminal/test/browser/terminalTabsStyles.test.ts | Adds styling regression tests. |
| src/vs/sessions/browser/parts/media/panelPart.css | Aligns list background without overriding drop targets. |
| src/vs/sessions/browser/media/workbench.css | Applies shared row geometry to terminal tabs. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Federico Brancasi (federicobrancasi)
approved these changes
Oct 14, 2026
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Benjamin Christopher Simmonds (@benibenj)Matched files:
|
Contributor
|
Base:
|
Lee Murray (mrleemurray)
deleted the
mrleemurray/agents/align-terminal-style-with-editor
branch
October 15, 2026 17:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the Agents window terminal instance list with the editor window’s Modern UI presentation.
Changes
Validation
npm run build-fast -- --client-only— passed.npm run build-fast— passed (full product build)../scripts/test.sh --run src/vs/sessions/contrib/terminal/test/browser/terminalTabsStyles.test.ts --reporter dot— passed, 10 tests reported by the runner.npm run eslint -- src/vs/sessions/contrib/terminal/test/browser/terminalTabsStyles.test.ts— passed.npm run stylelint -- src/vs/sessions/browser/media/workbench.css src/vs/sessions/browser/parts/media/panelPart.css— passed.git diff --check— passed.How to test
No linked issue was supplied.