Repository navigation
sessions: Preserve custom group for starting sessions - #339105
Merged
Megan Rogge (meganrogge) merged 3 commits intoOct 1, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 375ed100-bce0-433b-bd68-bf5cf34d9ed0
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Sandeep Somavarapu (@sandy081)Matched files:
|
Ladislau Szomoru (lszomoru)
previously approved these changes
Oct 1, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Pre-send draft replacement and provisional membership edits can still lose or override the intended group.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Preserves custom-group placement while new sessions start.
Changes:
- Exposes transient group membership for provisional sessions.
- Cleans up failed starts and adds lifecycle tests.
| File | Description |
|---|---|
sessionGroupsService.ts |
Tracks and exposes provisional membership. |
sessionGroupsService.test.ts |
Tests provisional, replacement, and failure flows. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Screenshot ChangesBase: Changed (3)
|
| Before | After |
|---|---|
 |
 |
sessions/accountMenu/WeeklyAndFiveHourLimits/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/DiscoverPluginsLoadingMore/Light
| Before | After |
|---|---|
 |
 |
2 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 375ed100-bce0-433b-bd68-bf5cf34d9ed0
roblourens
previously approved these changes
Oct 1, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 375ed100-bce0-433b-bd68-bf5cf34d9ed0
Alex Ross (alexr00)
approved these changes
Oct 1, 2026
Megan Rogge (meganrogge)
deleted the
merogge/fix-custom-group-in-flight-session
branch
October 1, 2026 16:00
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #339071
Capture pending custom-group placement when a provisional new session is published, expose that transient membership while the session starts, and clear it if startup fails. Durable membership is still saved only after the session starts.
Tests cover provisional publication, draft-to-committed session replacement, successful startup, and failed-start cleanup.
Testing
npm run transpile-client./scripts/test.sh --run src/vs/sessions/services/sessions/test/browser/sessionGroupsService.test.ts