Repository navigation
adopt to web platform specifier - #182072
Merged
Merged
Conversation
Sandeep Somavarapu (sandy081)
marked this pull request as ready for review
May 10, 2023 16:24
Sandeep Somavarapu (sandy081)
enabled auto-merge (squash)
May 10, 2023 16:25
Martin Aeschlimann (aeschli)
approved these changes
May 10, 2023
| } | ||
| return webExtension; | ||
| })); | ||
| if (update) { |
Contributor
There was a problem hiding this comment.
What if one of the web extension promises throws? That means we will never reach this code. Should there be some sort of finally handling here?
Member
Author
There was a problem hiding this comment.
There is a try/catch for each promise to log the error.
Contributor
There was a problem hiding this comment.
You're right! I missed that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#180525 adopt to web platform specifier