Skip to content

Don't fire VSTHRD100 for async lambdas/delegates #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Andrew Arnott (AArnott) merged 1 commit into from
Jul 28, 2022
Merged

Don't fire VSTHRD100 for async lambdas/delegates #1076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions src/Microsoft.VisualStudio.Threading.Analyzers/VSTHRD100AsyncVoidMethodAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public override void Initialize(AnalysisContext context)
context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.Analyze);

context.RegisterSymbolAction(Utils.DebuggableWrapper(AnalyzeNode), SymbolKind.Method);
context.RegisterOperationAction(Utils.DebuggableWrapper(AnalyzeOperation), OperationKind.LocalFunction, OperationKind.AnonymousFunction);
context.RegisterOperationAction(Utils.DebuggableWrapper(AnalyzeOperation), OperationKind.LocalFunction);
}

private static void AnalyzeNode(SymbolAnalysisContext context)
Expand All @@ -74,17 +74,7 @@ private static void AnalyzeOperation(OperationAnalysisContext context)
{
if (context.Operation is ILocalFunctionOperation localFunctionOperation)
{
AnalyzeSymbol(localFunctionOperation.Symbol);
}
else if (context.Operation is IAnonymousFunctionOperation anonymousFunctionOperation)
{
AnalyzeSymbol(anonymousFunctionOperation.Symbol);
}

return;

void AnalyzeSymbol(IMethodSymbol methodSymbol)
{
IMethodSymbol methodSymbol = localFunctionOperation.Symbol;
if (methodSymbol.IsAsync && methodSymbol.ReturnsVoid)
{
context.ReportDiagnostic(Diagnostic.Create(Descriptor, methodSymbol.Locations[0]));
Expand Down
38 changes: 0 additions & 38 deletions ...Microsoft.VisualStudio.Threading.Analyzers.Tests/VSTHRD100AsyncVoidMethodAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,44 +42,6 @@ async void F() {}
await Verify.VerifyAnalyzerAsync(test, expected);
}

[Fact]
public async Task ReportWarningOnAsyncVoidLambda()
Comment thread
AArnott marked this conversation as resolved.
Resolved
{
var test = @"
using System;
using System.Threading.Tasks;

class Test {
void M() {
F(async () => await Task.Delay(0));

void F(Action a) {}
}
}
";
CodeAnalysis.Testing.DiagnosticResult expected = Verify.Diagnostic().WithLocation(7, 11);
await Verify.VerifyAnalyzerAsync(test, expected);
}

[Fact]
public async Task ReportWarningOnAsyncVoidDelegate()
{
var test = @"
using System;
using System.Threading.Tasks;

class Test {
void M() {
F(async delegate() { await Task.Delay(0); });

void F(Action a) {}
}
}
";
CodeAnalysis.Testing.DiagnosticResult expected = Verify.Diagnostic().WithLocation(7, 11);
await Verify.VerifyAnalyzerAsync(test, expected);
}

[Fact]
public async Task ReportWarningOnAsyncVoidMethodSimilarToAsyncEventHandler()
{
Expand Down