Repository navigation
Reduce unnecessary disposing JTF dependencies & task continuations - #1017
Merged
Merged
Conversation
Also touch-up code comments and modify syntax to make it consistent across the two methods.
Andrew Arnott (AArnott)
approved these changes
Apr 8, 2022
Andrew Arnott (AArnott)
left a comment
Andrew Arnott (AArnott)
left a comment
Member
There was a problem hiding this comment.
Looks good. I push a minor change of my own. Please review it before merging, Lifeng Lu (@lifengl).
Member
Author
|
makes sense. thanks a lot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to improve performance of JoinAsync when a cancellation token is not being used.
The reason behind this is JoinAsync will only complete when the task being waited is completed. A completed JoinableTask will remove itself from the graph, so we don't need chain the task inside JoinAsync to clean up the new dependency.
It is more efficiently to do that:
1, removing dependency will need get into the global lock, which is a contention point of the product
2, removing the completed task will cut all dependencies in one operation, which is much efficient than removing dependencies one by one.
This will allow us not to have any new async state machine in that case, and cut off some unnecessary task continuation in the AsyncLazy, when GetValueAsync is called without a cancellation token.