Repository navigation
Support linter configuration overrides from the CLI - #12195
Open
Timothee Guerin (timotheeguerin) wants to merge 5 commits into
Open
Timothee Guerin (timotheeguerin) wants to merge 5 commits into
Timothee Guerin (timotheeguerin) wants to merge 5 commits into
Conversation
microsoft-github-policy-service
Bot
added
compiler:core
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Invalid inherited rule options still block compilation even when CLI overrides replace or disable them.
1 open finding
What changed in this PR
Adds runtime-only linter overrides to the TypeSpec compiler CLI without modifying project configuration.
Changes:
- Adds ruleset selection, per-rule overrides, and lint disabling.
- Adds unit and end-to-end coverage.
- Documents flags, precedence, and path resolution.
| File | Description |
|---|---|
| website/src/content/docs/docs/handbook/configuration/configuration.mdx | Documents override behavior. |
| website/src/content/docs/docs/handbook/cli.md | Introduces linter flags. |
| packages/compiler/test/e2e/cli/scenarios/linter/using-only.yaml | Adds ruleset fixture. |
| packages/compiler/test/e2e/cli/scenarios/linter/tspconfig.yaml | Configures scenario linting and emission. |
| packages/compiler/test/e2e/cli/scenarios/linter/main.tsp | Supplies lint-triggering source. |
| packages/compiler/test/e2e/cli/cli.e2e.ts | Tests CLI behavior. |
| packages/compiler/test/core/linter.test.ts | Updates diagnostic expectation. |
| packages/compiler/test/cli.test.ts | Tests override parsing and precedence. |
| packages/compiler/src/core/types.ts | Clarifies file-reference documentation. |
| packages/compiler/src/core/program.ts | Applies runtime overrides. |
| packages/compiler/src/core/options.ts | Adds internal override options. |
| packages/compiler/src/core/messages.ts | Adds flag diagnostics. |
| packages/compiler/src/core/linter.ts | Updates origin commentary. |
| packages/compiler/src/core/cli/cli.ts | Registers linter flags. |
| packages/compiler/src/core/cli/actions/compile/args.ts | Parses and resolves overrides. |
| .chronus/changes/feat-cli-linter-config-2026-9-14-22-11-54.md | Announces the feature. |
🧠 Review effort: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Timothee Guerin (timotheeguerin)
marked this pull request as ready for review
October 15, 2026 14:03
Timothee Guerin (timotheeguerin)
requested review from
catalinaperalta,
iscai-msft,
Laurent Mazuel (lmazuel) and
Mark Cowlishaw (markcowl)
as code owners
October 15, 2026 14:03
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing lint policy for a single compilation currently requires editing
tspconfig.yamlor maintaining a separate config, even when the goal is just to skip linting or try another ruleset.Add runtime-only overrides without changing the project's configuration:
--linter-rulesetcan be repeated and accepts library rulesets orfile:YAML references. It replaces the configuredextendslist while preserving configured per-rule settings. CLI file paths resolve from the working directory.--linter-ruleacceptstrue,false, or a JSON options object and takes precedence over configured rule settings.--no-linterdisables lint rules without suppressing compiler diagnostics or emitters, and cannot be combined with either override flag.