Repository navigation
Port content mapper changes to rewriteRelativeImportExtension - #295
Open
Andrew Branch (andrewbranch) wants to merge 1 commit into
Open
Andrew Branch (andrewbranch) wants to merge 1 commit into
Andrew Branch (andrewbranch) wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
Static review found consistent implementations, aligned declarations, and focused regression coverage with no unresolved findings; tests were not run.
No open issues 🎉
What changed in this PR
Ports TypeScript’s additional extension-mapping support to tslib’s relative import rewrite helper.
Changes:
- Adds custom extension mappings and optional case-insensitive matching across all runtime variants.
- Updates the declaration and parameter documentation.
- Adds regression tests for mapping precedence, identity mappings, and existing fallback behavior.
| File | Description |
|---|---|
tslib.js |
Adds mapping support to the CommonJS/UMD helper. |
tslib.es6.mjs |
Adds mapping support to the .mjs helper. |
tslib.es6.js |
Adds mapping support to the ES module helper. |
tslib.d.ts |
Declares and documents the new parameters. |
test/node/rewriteRelativeImportExtension.test.js |
Covers custom mappings and compatibility behavior. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port from microsoft/TypeScript#64581