Repository navigation
ci: removes extraneous nuget.config file - #14341
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates contributor documentation to help Microsoft developers using CFS avoid .NET dependency restore failures caused by the repo’s local NuGet configuration.
Changes:
- Adds a CONTRIBUTING.md note for Microsoft contributors using CFS about removing
dotnet/nuget.configbefore runningdotnet restore. - Clarifies that the change is local-only and should not be committed.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Suppressed comments (2)
CONTRIBUTING.md:122
- These commands will error if the file has already been removed. Using idempotent variants (and PowerShell error suppression) makes the instructions easier to follow.
# macOS/Linux
rm dotnet/nuget.config
# PowerShell
Remove-Item dotnet/nuget.config
CONTRIBUTING.md:124
- The term “CFS rewrite” (and the CFS acronym) isn’t defined anywhere else in this document. Consider expanding the acronym on first use or linking to a brief explanation so contributors know whether this applies to them.
This local-only change should not be committed. Removing the file allows the CFS rewrite to handle package feed rewriting correctly during `dotnet restore`.
…nd is problematic with CFS users
Vincent Biret (baywet)
force-pushed
the
docs/cfs-contributors
branch
from
August 26, 2026 16:15
3e77482 to
79fdd9d
Compare
westey (westey-m)
approved these changes
Aug 26, 2026
Vincent Biret (baywet)
temporarily deployed
to
integration
August 26, 2026 16:32 — with
GitHub Actions
Inactive
SergeyMenshykh
approved these changes
Aug 27, 2026
SergeyMenshykh
temporarily deployed
to
integration
August 27, 2026 16:08 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CFS users will get dependencies restoration issues in dotnet unless they remove the nuget.config locally. This pull request documents that so they get unstuckafter further discussions, this only carries the default configuration any dotnet user should have. And it's problematic for CFS users. So we'll simply remove the nuget.config file.