Skip to content

ci: removes extraneous nuget.config file - #14341

Merged
SergeyMenshykh merged 2 commits into
microsoft:mainfrom
baywet:docs/cfs-contributors
Aug 27, 2026
Merged

SergeyMenshykh merged 2 commits into
microsoft:mainfrom
baywet:docs/cfs-contributors

Conversation

@baywet

@baywet Vincent Biret (baywet) commented Aug 26, 2026 •

Copy link
Copy Markdown
Member

CFS users will get dependencies restoration issues in dotnet unless they remove the nuget.config locally. This pull request documents that so they get unstuck

after further discussions, this only carries the default configuration any dotnet user should have. And it's problematic for CFS users. So we'll simply remove the nuget.config file.

Copilot AI lite review requested due to automatic review settings August 26, 2026 15:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates contributor documentation to help Microsoft developers using CFS avoid .NET dependency restore failures caused by the repo’s local NuGet configuration.

Changes:

  • Adds a CONTRIBUTING.md note for Microsoft contributors using CFS about removing dotnet/nuget.config before running dotnet restore.
  • Clarifies that the change is local-only and should not be committed.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread CONTRIBUTING.md Resolved
Comment thread CONTRIBUTING.md Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Suppressed comments (2)

CONTRIBUTING.md:122

  • These commands will error if the file has already been removed. Using idempotent variants (and PowerShell error suppression) makes the instructions easier to follow.
    # macOS/Linux
    rm dotnet/nuget.config

    # PowerShell
    Remove-Item dotnet/nuget.config

CONTRIBUTING.md:124

  • The term “CFS rewrite” (and the CFS acronym) isn’t defined anywhere else in this document. Consider expanding the acronym on first use or linking to a brief explanation so contributors know whether this applies to them.
This local-only change should not be committed. Removing the file allows the CFS rewrite to handle package feed rewriting correctly during `dotnet restore`.

Comment thread CONTRIBUTING.md Resolved
@baywet
Vincent Biret (baywet) requested a review from a team as a code owner August 26, 2026 16:15
@baywet Vincent Biret (baywet) changed the title docs: updates the contributing information for CFS users ci: removes extraneous nuget.config file Aug 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@SergeyMenshykh
SergeyMenshykh merged commit a64827e into microsoft:main Aug 27, 2026
18 checks passed
@baywet
Vincent Biret (baywet) deleted the docs/cfs-contributors branch August 27, 2026 16:38

This branch was previously deployed

1 inactive deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants