Skip to content

Switch failing test to new model. - #14332

Merged
westey (westey-m) merged 4 commits into
microsoft:mainfrom
westey-m:skip-failing-websearch-test
Aug 26, 2026
Merged

westey (westey-m) merged 4 commits into
microsoft:mainfrom
westey-m:skip-failing-websearch-test

Conversation

@westey-m

@westey-m westey (westey-m) commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

Motivation and Context

The model used by this test is deprecated and the test is blocking merges.

Description

Switch to replacement model

Contribution Checklist

Copilot AI lite review requested due to automatic review settings August 26, 2026 09:13
@westey-m
westey (westey-m) requested a review from a team as a code owner August 26, 2026 09:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables an OpenAI integration test that is currently failing due to reliance on a deprecated model, unblocking merges while the test scenario is revisited.

Changes:

  • Mark ChatCompletionWithWebSearchAsync as skipped with an explanatory reason.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAF Automated Review — Iteration 1

Result: No findings
Scope: full PR (1 commit(s)): a809e96e5a7c
Model: claude-opus-4.8

Overview

This PR makes a single test-only change: it replaces [RetryFact] with [Fact(Skip = "...")] on the ChatCompletionWithWebSearchAsync integration test so the deprecated gpt-4o-search-preview model no longer blocks merges. The change touches no production code, package boundary, or public contract, and it conforms to an existing convention in the same file ([Fact(Skip = ...)] at line 166, with a file-level #pragma warning disable xUnit1004 at line 21). The repository sets no warnings-as-errors, so the resulting unused using xRetry; cannot break the build. There is no publishable defect.

Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.

@westey-m westey (westey-m) changed the title Skip failing test that uses a deprecated model. Switch failing test to new model. Aug 26, 2026

@adamsitnik Adam Sitnik (adamsitnik) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for unblocking the CI westey (@westey-m) !

@westey-m
westey (westey-m) added this pull request to the merge queue Aug 26, 2026
Merged via the queue into microsoft:main with commit cd7b533 Aug 26, 2026
18 checks passed
@westey-m
westey (westey-m) deleted the skip-failing-websearch-test branch August 26, 2026 10:59

This branch was previously deployed

1 inactive deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants