Repository navigation
Switch failing test to new model. - #14332
Conversation
There was a problem hiding this comment.
Pull request overview
This PR disables an OpenAI integration test that is currently failing due to reliance on a deprecated model, unblocking merges while the test scenario is revisited.
Changes:
- Mark
ChatCompletionWithWebSearchAsyncas skipped with an explanatory reason.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: No findings
Scope: full PR (1 commit(s)): a809e96e5a7c
Model: claude-opus-4.8
Overview
This PR makes a single test-only change: it replaces [RetryFact] with [Fact(Skip = "...")] on the ChatCompletionWithWebSearchAsync integration test so the deprecated gpt-4o-search-preview model no longer blocks merges. The change touches no production code, package boundary, or public contract, and it conforms to an existing convention in the same file ([Fact(Skip = ...)] at line 166, with a file-level #pragma warning disable xUnit1004 at line 21). The repository sets no warnings-as-errors, so the resulting unused using xRetry; cannot break the build. There is no publishable defect.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.
Adam Sitnik (adamsitnik)
left a comment
There was a problem hiding this comment.
LGTM, thank you for unblocking the CI westey (@westey-m) !
Motivation and Context
The model used by this test is deprecated and the test is blocking merges.
Description
Switch to replacement model
Contribution Checklist