Skip to content

.Net: Add hybrid search abstraction and azure ai search implementation - #10441

Merged
westey (westey-m) merged 5 commits into
microsoft:feature-keyword-hybrid-searchfrom
westey-m:kh-abstraction-azureaisearch
Feb 12, 2025
Merged

.Net: Add hybrid search abstraction and azure ai search implementation#10441
westey (westey-m) merged 5 commits into
microsoft:feature-keyword-hybrid-searchfrom
westey-m:kh-abstraction-azureaisearch

Conversation

@westey-m

@westey-m westey (westey-m) commented Feb 6, 2025

Copy link
Copy Markdown
Contributor

Motivation and Context

#9399

Adding the ADR, Keyword Hybrid Search abstractions and an implementation with integration tests for Azure AI Search.

Description

Adding the ADR, Keyword Hybrid Search abstractions and an implementation with integration tests for Azure AI Search.
More implementations to follow.

Contribution Checklist

@westey-m
westey (westey-m) requested a review from a team as a code owner February 6, 2025 17:30
@markwallace-microsoft Mark Wallace (markwallace-microsoft) added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel documentation memory labels Feb 6, 2025
@github-actions github-actions Bot changed the title Add hybrid search abstraction and azure ai search implementation .Net: Add hybrid search abstraction and azure ai search implementation Feb 6, 2025
dmytrostruk
Dmytro Struk (dmytrostruk) approved these changes Feb 6, 2025
View reviewed changes
Comment thread .../src/Connectors/VectorData.Abstractions/VectorSearch/KeywordVectorizedHybridSearchOptions.cs Resolved
Comment thread ...IntegrationTests/Connectors/Memory/AzureAISearch/AzureAISearchConfigSetConditionAttribute.cs Resolved
Comment thread ...IntegrationTests/Connectors/Memory/AzureAISearch/CommonKeywordVectorizedHybridSearchTests.cs Resolved
Comment thread dotnet/src/InternalUtilities/src/Data/VectorStoreRecordPropertyReader.cs Resolved
Comment thread dotnet/src/InternalUtilities/src/Data/VectorStoreRecordPropertyReader.cs Resolved
markwallace-microsoft
Mark Wallace (markwallace-microsoft) approved these changes Feb 10, 2025
View reviewed changes
Comment thread dotnet/src/InternalUtilities/src/Data/VectorStoreRecordPropertyReader.cs Resolved
Comment thread docs/decisions/00NN-hybrid-search.md Resolved
roji
Shay Rojansky (roji) approved these changes Feb 11, 2025
View reviewed changes
Comment thread ...t/src/Connectors/Connectors.Memory.AzureAISearch/AzureAISearchVectorStoreRecordCollection.cs Resolved
Comment thread dotnet/src/Connectors/VectorData.Abstractions/VectorSearch/IKeywordVectorizedHybridSearch.cs Resolved
Comment thread dotnet/src/Connectors/VectorData.Abstractions/VectorSearch/IKeywordVectorizedHybridSearch.cs Resolved
Comment thread ...rc/IntegrationTests/Connectors/Memory/AzureAISearch/AzureAISearchConfigConditionAttribute.cs Resolved
@westey-m
westey (westey-m) merged commit 164d02d into microsoft:feature-keyword-hybrid-search Feb 12, 2025

This branch was previously deployed

1 inactive deployment
integration — 34a38fdb Deployed Feb 11, 2025 by westey-m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmytrostruk Dmytro Struk (dmytrostruk) dmytrostruk approved these changes
@roji Shay Rojansky (roji) roji approved these changes
@SergeyMenshykh SergeyMenshykh SergeyMenshykh approved these changes
+1 more reviewer
@markwallace-microsoft Mark Wallace (markwallace-microsoft) markwallace-microsoft approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation kernel Issues or pull requests impacting the core kernel memory .NET Issue or Pull requests regarding .NET code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@westey-m @roji @dmytrostruk @SergeyMenshykh @markwallace-microsoft