Skip to content

[@microsoft/rush-lib] Git 'pre-push' hooks didn't handle error correctly #4247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ian Clanton-Thuon (iclanton) merged 4 commits into from
Jul 24, 2023
Merged

[@microsoft/rush-lib] Git 'pre-push' hooks didn't handle error correctly #4247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b8de132
push not fail when pre-push failed
kamontat Jul 20, 2023
d5bc48c
Create fix-pre-push-hook_2023-07-20-21-26.json
kamontat Jul 20, 2023
1a0e02b
fix: invalid change path
kamontat Jul 20, 2023
93d0bf7
Rush change.
iclanton Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@microsoft/rush/fix-pre-push-hook_2023-07-20-21-26.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@microsoft/rush",
"comment": "Fix an issue where the git pre-push hook would allow push to go through if the script exited with error.",
"type": "patch"
}
],
"packageName": "@microsoft/rush"
}
1 change: 1 addition & 0 deletions libraries/rush-lib/src/logic/base/BaseInstallManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,6 +483,7 @@ fi
: '';

const hookFileContent: string = `#!/bin/bash
set -e
SCRIPT_DIR="$( cd "$( dirname "\${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
SCRIPT_IMPLEMENTATION_PATH="$SCRIPT_DIR/${hookRelativePath}/${filename}"

Expand Down