Repository navigation
fix(chromium): preserve fonts when connecting with noDefaults - #43773
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| }); | ||
|
|
||
| test('CD-034 should skip default overrides with noDefaults', async ({ browserType, mode, server }, testInfo) => { | ||
| test('CD-034 should skip default overrides with noDefaults', { |
Collaborator
There was a problem hiding this comment.
Let's undo the changes to the test, except for the annotation.
Contributor
|
Hi, I'm the Playwright bot. I started to address the review comments on Linux: agent run |
#43773 (comment): Restored the original CD-034 test body, keeping only the issue annotation; the font fix and documentation are unchanged.
microsoft-playwright-automation
Bot
force-pushed
the
triage/43715/40944916913-1
branch
from
October 30, 2026 11:56
8a0b169 to
0bc2334
Compare
Contributor
Test results for "tests 1"23599 passed, 705 skipped Merge workflow run. |
Contributor
Test results for "MCP"5194 passed, 616 skipped Merge workflow run. |
Dmitry Gozman (dgozman)
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The headless font override did not check
noDefaults, so attaching over CDP changed font settings in the existing default context. Use the same guard as focus and media emulation, and document that font settings are preserved.Extend the existing CD-034 test to verify that an existing page keeps its text width after reconnecting with
noDefaults.Verified the regression fails without the fix and passes with it. CDP and neighbouring worker connection suites: 38 passed, 1 existing fixme skipped. CD-034 and CD-035 also pass headed. Build and flint passed.
Fixes #43715
Prepared by the triage workflow.