Skip to content

chore(firefox): note legacy downloads removal - #43737

Merged
Dmitry Gozman (dgozman) merged 2 commits into
mainfrom
triage/43547/40780413120-1
Oct 29, 2026
Merged

Dmitry Gozman (dgozman) merged 2 commits into
mainfrom
triage/43547/40780413120-1

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

Add the requested removal TODO beside PLAYWRIGHT_FIREFOX_LEGACY_DOWNLOADS, without changing download behavior.

npm run build and npm run flint passed on Linux. An exact-source comparison confirmed the TODO is the only change; no regression test is needed for a comment-only change.

Fixes: #43547

Prepared by the triage workflow.

@dgozman
Dmitry Gozman (dgozman) marked this pull request as ready for review October 28, 2026 22:37
downloadOptions: {
behavior: this._options.acceptDownloads === 'accept' ? 'saveToDisk' : 'cancel',
downloadsDir: this._browser.options.downloadsPath,
// TODO: remove after v1.56 release if no issues were found

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think 1.56 or 1.65 is a good reference. I'd say Remove Dec 2026. // TODO(time:12/2026): remove.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot. I started to address the review comments on Linux: agent run

@github-actions

This comment has been minimized.

Address #43737 (comment): replace the release reference with TODO(time:12/2026): remove.; download behavior is unchanged.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

5194 passed, 616 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [chromium-library] › library/video.spec.ts:762 › screencast › VI-030 should work with video+trace @chromium-playwright-x64-ubuntu24-64-core-node22

23592 passed, 707 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 CI failure is a confirmed pre-existing flake

Hi, I'm the Playwright bot. I checked the latest CI report, the PR diff, and refreshed test history.

Details

The latest merged report has one failed test. This PR only adds a removal TODO beside PLAYWRIGHT_FIREFOX_LEGACY_DOWNLOADS in ffBrowser.ts; it changes no behavior and cannot affect Chromium video or tracing.

Pre-existing flake

[chromium-library] › library/video.spec.ts:762 › screencast › VI-030 should work with video+trace — on Ubuntu, the trace has no screencast-frame, so reading frame.file throws TypeError: Cannot read properties of undefined (reading 'file'). It failed on the initial attempt and all three retries in this PR's Chromium job.

The refreshed results database confirms the same test and error outside this PR:

  • On the same CI bot, chromium-playwright-x64-ubuntu24-64-core-node22, it failed twice, then passed on the third attempt in #43694's run.
  • On main at this PR's base, c78117362861a84d5b2f0cf988a02f9963a2a958, it failed, then passed on retry on three Chromium/Linux configurations in run 40780631047.

These independent occurrences establish a pre-existing flake, not a regression from this PR.

Triaged by the Playwright bot - agent run

@dgozman
Dmitry Gozman (dgozman) merged commit ac44835 into main Oct 29, 2026
23 of 24 checks passed
@dgozman
Dmitry Gozman (dgozman) deleted the triage/43547/40780413120-1 branch October 29, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[internal] remove PLAYWRIGHT_FIREFOX_LEGACY_DOWNLOADS

2 participants