Repository navigation
chore(firefox): note legacy downloads removal - #43737
Conversation
| downloadOptions: { | ||
| behavior: this._options.acceptDownloads === 'accept' ? 'saveToDisk' : 'cancel', | ||
| downloadsDir: this._browser.options.downloadsPath, | ||
| // TODO: remove after v1.56 release if no issues were found |
There was a problem hiding this comment.
I don't think 1.56 or 1.65 is a good reference. I'd say Remove Dec 2026. // TODO(time:12/2026): remove.
This comment has been minimized.
This comment has been minimized.
|
Hi, I'm the Playwright bot. I started to address the review comments on Linux: agent run |
This comment has been minimized.
This comment has been minimized.
Address #43737 (comment): replace the release reference with TODO(time:12/2026): remove.; download behavior is unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Test results for "MCP"5194 passed, 616 skipped Merge workflow run. |
Test results for "tests 1"1 failed 23592 passed, 707 skipped Merge workflow run. |
🟢 CI failure is a confirmed pre-existing flakeHi, I'm the Playwright bot. I checked the latest CI report, the PR diff, and refreshed test history. DetailsThe latest merged report has one failed test. This PR only adds a removal TODO beside Pre-existing flake
The refreshed results database confirms the same test and error outside this PR:
These independent occurrences establish a pre-existing flake, not a regression from this PR. Triaged by the Playwright bot - agent run |
Add the requested removal TODO beside
PLAYWRIGHT_FIREFOX_LEGACY_DOWNLOADS, without changing download behavior.npm run buildandnpm run flintpassed on Linux. An exact-source comparison confirmed the TODO is the only change; no regression test is needed for a comment-only change.Fixes: #43547
Prepared by the triage workflow.