Repository navigation
Stabilize XamlMessageBox UI-thread dispatch test - #2430
Merged
Brian Robbins (brianrob) merged 1 commit intoMay 28, 2026
Merged
Brian Robbins (brianrob) merged 1 commit into
Brian Robbins (brianrob) merged 1 commit into
Conversation
Use xUnit's WPF dispatcher for the XamlMessageBox background-thread dispatch regression test instead of creating and shutting down a private dispatcher thread. This avoids intermittent hangs from dispatcher/Application state while preserving the regression coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
| Dispatcher.CurrentDispatcher.InvokeShutdown(); | ||
| }; | ||
| Application app = Application.Current ?? new Application(); | ||
| app.ShutdownMode = ShutdownMode.OnExplicitShutdown; |
There was a problem hiding this comment.
If you have multiple WPF based tests, it might be worth using an IFixture to set these things up. But if it's the only test, not worth bothering with.
This was referenced Jun 16, 2026
Merged
This was referenced Jun 17, 2026
Merged
Closed
This was referenced Jun 25, 2026
Merged
This was referenced Aug 10, 2026
This was referenced Aug 17, 2026
Open
This was referenced Aug 28, 2026
This was referenced Sep 6, 2026
This was referenced Sep 16, 2026
This was referenced Sep 28, 2026
This was referenced Oct 15, 2026
This was referenced Oct 26, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Show_AutoDispatchesToUIThreadFromBackgroundThreadto use xUnit's[WpfFact]dispatcher instead of manually creating and shutting down a WPF dispatcher thread.XamlMessageBox.Showcall directly and keep a timeout assertion for clearer failure behavior.Validation
PerfViewTests.dllruns passed after the change, with 87/87 tests passing each run.