Repository navigation
Enable Spectre mitigations and linker optimizations for EtwClrProfiler - #2410
Merged
Jiri Cincura ↹ (cincuranet) merged 1 commit intoApr 15, 2026
Merged
Jiri Cincura ↹ (cincuranet) merged 1 commit into
Jiri Cincura ↹ (cincuranet) merged 1 commit into
Conversation
Add build hardening flags to resolve BinSkim findings now that EtwClrProfiler is included in the official scan (PR 727750). Both x86 and x64 vcxproj: - BA2024: Enable Spectre mitigations (/Qspectre) in Debug and Release - BA6004: Enable COMDAT folding (/OPT:ICF) in Release - BA6005: Enable Optimize References (/OPT:REF) in Release - BA6006: Enable Link-Time Code Generation (/LTCG + /GL) in Release Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
|
did some validation building with this --
|
Jiri Cincura ↹ (cincuranet)
approved these changes
Apr 15, 2026
This was referenced May 20, 2026
Merged
This was referenced May 20, 2026
Merged
This was referenced May 31, 2026
This was referenced Jun 16, 2026
This was referenced Aug 2, 2026
This was referenced Aug 10, 2026
This was referenced Aug 17, 2026
This was referenced Aug 28, 2026
This was referenced Sep 6, 2026
This was referenced Sep 16, 2026
This was referenced Sep 28, 2026
This was referenced Oct 15, 2026
This was referenced Oct 26, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add build hardening flags to resolve BinSkim findings now that EtwClrProfiler is included in the official scan (PR 727750).
Untested and not suggesting you should take any of these (AFAIK none are required by SDL currently). Feel free to pick any all or none.
Both x86 and x64 vcxproj: