Repository navigation
add horizontal scrolling to eventviewer - #2361
Conversation
|
@microsoft-github-policy-service agree company="Microsoft" |
Brian Robbins (brianrob)
left a comment
Brian Robbins (brianrob)
left a comment
There was a problem hiding this comment.
Looks great! Just one improvement request below.
| { | ||
| if (Keyboard.Modifiers == ModifierKeys.Shift) | ||
| { | ||
| var scrollViewer = FindVisualChild<ScrollViewer>((DependencyObject)sender); |
There was a problem hiding this comment.
I believe this should be cacheable so that you don't have to find it on each event.
There was a problem hiding this comment.
added a commit, let me know if this is what you meant by caching
Brian Robbins (brianrob)
left a comment
Brian Robbins (brianrob)
left a comment
There was a problem hiding this comment.
Yes, this is what I'm talking about. Let's see if we can optimize this just a bit more since we're going to go through this path a whole bunch during scrolling. Take a look below - we should be able to eliminate one of the null checks.
|
made that improvement |
Brian Robbins (brianrob)
left a comment
Brian Robbins (brianrob)
left a comment
There was a problem hiding this comment.
LGTM. Thanks Logan George (@logangeorge01)!
add support for shift+scroll horizontal scrolling in eventviewer