Repository navigation
Special-Case BitMask Parsing - #2327
Merged
Brian Robbins (brianrob) merged 2 commits intoNov 7, 2025
Merged
Conversation
When an event contains a bitmask, it is sometimes described in metadata as an array of pointers. ETW differentiates between input and output types, and so there is a possibility for metadata to specify the input type as an array of UInt64 and the output type as an array of IntPtr. Existing code can't handle this properly, so we must special case it. The MSNT_SystemTrace/SystemConfig/ProcessorGroup event is an example of one such event.
Brian Robbins (brianrob)
requested review from
Jiri Cincura ↹ (cincuranet),
Lee Culver (leculver),
Mark Miller (marklio) and
Matt Connew (mconnew)
as code owners
November 6, 2025 21:39
Contributor
|
ok, the InvalidCastException is gone with the artifact build from this PR: |
Lee Culver (leculver)
previously approved these changes
Nov 7, 2025
Lee Culver (leculver)
left a comment
Lee Culver (leculver)
left a comment
Collaborator
There was a problem hiding this comment.
Small nitpick, otherwise looks fine to me.
| // input=Array of ulong | ||
| // output=Array of IntPtr | ||
| // This is common for bitmasks. To address this, we special case it here. | ||
| if (value is ulong && elementType == typeof(IntPtr)) |
Collaborator
There was a problem hiding this comment.
I'd combine the unboxing operation with pattern matching.
if (elementType == typeof(IntPtr) && value is ulong uintVal)
{
value = new IntPtr(unchecked((long)uintVal));
}
Member
Author
There was a problem hiding this comment.
Oh yes, I like that a lot better. Pushing that change.
Brian Robbins (brianrob)
enabled auto-merge (squash)
November 7, 2025 16:36
Lee Culver (leculver)
approved these changes
Nov 7, 2025
This was referenced Jan 29, 2026
Merged
Merged
This was referenced Feb 25, 2026
This was referenced Aug 10, 2026
This was referenced Aug 17, 2026
This was referenced Aug 28, 2026
This was referenced Sep 6, 2026
This was referenced Sep 16, 2026
This was referenced Sep 28, 2026
This was referenced Oct 15, 2026
This was referenced Oct 26, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an event contains a bitmask, it is sometimes described in metadata as an array of pointers. ETW differentiates between input and output types, and so there is a possibility for metadata to specify the input type as an array of UInt64 and the output type as an array of IntPtr. Existing code can't handle this properly, so we must special case it.
The MSNT_SystemTrace/SystemConfig/ProcessorGroup event is an example of one such event.