Skip to content

Upgrade node-gyp for Visual Studio 2026 - #997

Open
Anthony Kim (anthonykim1) wants to merge 2 commits into
mainfrom
anthonykim1/upgrade-node-gyp-windows-arm64
Open

Anthony Kim (anthonykim1) wants to merge 2 commits into
mainfrom
anthonykim1/upgrade-node-gyp-windows-arm64

Conversation

@anthonykim1

@anthonykim1 Anthony Kim (anthonykim1) commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Unblocks: #995

  • Raise the node-gyp development dependency from ^11.4.2 to ^12.1.0 and refresh its locked dependency graph.
  • Use the first node-gyp release that recognizes Visual Studio 2026 (18.x), which is the only Visual Studio version on the current Windows ARM runner image.
  • Add min-release-age=7 to .npmrc so newly published transitive dependencies have a week to reach the build feeds before npm selects them.
  • Re-resolve undici to 6.29.0, avoiding the newer 6.29.1 tarball that is not yet available from the Monaco npm feed.
  • Keep the existing CI matrix unchanged so windows-11-arm continues to verify the native build on ARM64.
  • Stay on node-gyp 12 to retain Node.js 20 support instead of adopting node-gyp 13's narrower engine range.

Inspirations from:

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@anthonykim1
Anthony Kim (anthonykim1) marked this pull request as draft October 20, 2026 23:52
@anthonykim1
Anthony Kim (anthonykim1) marked this pull request as ready for review October 20, 2026 23:53

@deepak1556 Robo (deepak1556) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we drop the node-gyp dependency and rely on the bundled version from npm, our current use cases can be switched to it and avoids developer churn in managing this dependency. You can make engine requirements strict on the package manifest to support VS 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants