Repository navigation
Upgrade node-gyp for Visual Studio 2026 - #997
Open
Anthony Kim (anthonykim1) wants to merge 2 commits into
Open
Anthony Kim (anthonykim1) wants to merge 2 commits into
Anthony Kim (anthonykim1) wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Anthony Kim (anthonykim1)
marked this pull request as draft
October 20, 2026 23:52
Anthony Kim (anthonykim1)
marked this pull request as ready for review
October 20, 2026 23:53
Robo (deepak1556)
left a comment
Contributor
There was a problem hiding this comment.
Can we drop the node-gyp dependency and rely on the bundled version from npm, our current use cases can be switched to it and avoids developer churn in managing this dependency. You can make engine requirements strict on the package manifest to support VS 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks: #995
node-gypdevelopment dependency from^11.4.2to^12.1.0and refresh its locked dependency graph.min-release-age=7to.npmrcso newly published transitive dependencies have a week to reach the build feeds before npm selects them.undicito 6.29.0, avoiding the newer 6.29.1 tarball that is not yet available from the Monaco npm feed.windows-11-armcontinues to verify the native build on ARM64.Inspirations from:
build-testmatrix, and dependency installation continues throughnpm ci.