Repository navigation
fix(abstractions): require std-uritemplate 2.0.13, which keeps commas in paths - #206
Open
Andrea Peruffo (andreaTP) wants to merge 1 commit into
Open
Andrea Peruffo (andreaTP) wants to merge 1 commit into
Andrea Peruffo (andreaTP) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the dependency update and its comma-preservation regression spec.
No open issues 🎉
What changed in this PR
Updates Kiota Ruby’s abstractions dependency to prevent commas from being dropped between function parameters in URI paths.
Changes:
- Raises the minimum
stduritemplateversion to2.0.13, retaining the< 2.1.0upper bound. - Adds a regression spec verifying that URI expansion preserves commas between path function parameters.
| File | Description |
|---|---|
components/abstractions/spec/request_information_uri_spec.rb |
Adds coverage for preserving commas in function-style paths. |
components/abstractions/microsoft_kiota_abstractions.gemspec |
Requires the dependency version containing the comma-preservation fix. |
Review effort: Balanced
Vincent Biret (baywet)
approved these changes
Nov 2, 2026
Vincent Biret (baywet)
enabled auto-merge
November 2, 2026 16:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std-uritemplate before 2.0.13 dropped the commas between function parameters (std-uritemplate/std-uritemplate#570), so
getPstnCalls(fromDateTime={fromDateTime},toDateTime={toDateTime})was sent asgetPstnCalls(fromDateTime=...toDateTime=...). Requires the fixed version and adds a spec for it.