Repository navigation
Anchor lock-expiration validation to the first claim - #76
Open
Thom Chiovoloni (thomcc-work) wants to merge 1 commit into
Open
Thom Chiovoloni (thomcc-work) wants to merge 1 commit into
Thom Chiovoloni (thomcc-work) wants to merge 1 commit into
Conversation
Measure the concurrent checks from the first completed claim rather than the startup barrier. Connection acquisition could otherwise consume the expiry margin and make a correct provider fail validation. Add a delayed-fetch regression and compare the recovered token with the original claim's token. Lease durations and timing margins are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a timing assumption in the multi-threaded lock-expiration provider
validation. Previously, the recovery wait started at a task-start barrier,
before the first fetch had acquired its lease. A slow connection acquisition
could consume the 100 ms expiry margin, causing the recovery fetch to run
while the lease was still valid.
This change:
completed claim.
lease duration plus recovery margin.
The requested lease duration and existing timing margins remain unchanged.
There are no production provider or runtime behavior changes.
Checklist
cargo nt)cargo test --doc --all-features)docs/if introducing a new areadocs/README.mdDiscovered while reviewing microsoft/duroxide-pg#41.