This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Use bounded typescript version? #159
Description
The following change in my yarn.lock is breaking our typescript tests:
typescript@next:
- version "3.2.0-dev.20181004"
- resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.2.0-dev.20181004.tgz#ac75518858a134a7a3345b23c67ce5c6333279f6"
- integrity sha512-Z23RIddFV2Nnze2j4AT/NewQ9aeMOzxVYKUZwDormi/eKL/6v7SlHIelXpweVYIHy6gPpV1HMhFxBQ4+f8TrxA==
+ version "3.2.0-dev.20181117"
+ resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.2.0-dev.20181117.tgz#58a8cab074668a0e33ced2bc3c537dc5531c6eee"
+ integrity sha512-SWiOhEQfhelK6Jb6g2fU2AHUnXhY10xeCVweMZCAlmTGKiDhq5inJfn3cHNPNcRd3xFLAsEdE2Wqdoz8iCy4OA==Turn out, that change was allowed by this dependency typescript scope:
https://github.com/Microsoft/dtslint/blob/73a196741d5b6ca9af7f6ef68ef4ee3e801ac4b5/package.json#L31
Wouldn't it be better to have scoped version, not allowing any typescript version that might break in the future?
Reacted by Jennifer Shehane, Kevin Ross, Ankur Oberoi and Charles Lowell
Activity
eps1lon commentedon Feb 2, 2019
Andy (Andrewkraft) (@Andy-MS) This is again breaking our tests since typescript changed the enum values for
SyntaxKind.The issue here is that using
dtslintessentially requires users to usetypescript@next:tslinthas a peerDependency ontypescriptso if one uses e.g.typescript@3.2thentslintwill parse the source withtypescript@3.2. This results in nodes with different syntax kind enum values that are not recognized bytypescript@next.microsoft/TypeScript#25886 caused such an issue:
tslintwill create an AST where anexport default ...node will have a modifier with the kind84which is theExportKeywordintypescript@3.2but since typescript 3.3 added theBigIntLiteralKeywordtoSyntaxKindintypescript@nextExportKeywill have the value 85. This reports a false positive in thestrict-export-declare-modifer-rule.