Repository navigation
Update the ThreadPool command to handle both Portable and Windows thread pool - #1175
Merged
Eduardo Velarde (eduardo-vp) merged 13 commits intoSep 29, 2023
Merged
Eduardo Velarde (eduardo-vp) merged 13 commits into
Eduardo Velarde (eduardo-vp) merged 13 commits into
Conversation
Eduardo Velarde (eduardo-vp)
requested a review
from Koundinya Veluri (kouvel)
August 15, 2023 03:35
Eduardo Velarde (eduardo-vp)
marked this pull request as draft
August 15, 2023 03:35
Contributor
|
Hey! I'm in the process of migrating the codebase here over to dotnet/diagnostics. The code will remain the same, but the relative path of the files and location of the repo will change. This will make migrating your change annoying (but not impossible). Are you ready to wrap up this change? It's no problem if you aren't yet ready. If you need more time, you may need to generate a patch for the diff (maybe try Thanks! |
Eduardo Velarde (eduardo-vp)
marked this pull request as ready for review
August 22, 2023 18:33
Lee Culver (leculver)
approved these changes
Sep 26, 2023
Lee Culver (leculver)
left a comment
Lee Culver (leculver)
left a comment
Contributor
There was a problem hiding this comment.
LGTM, I have two minor suggestions.
Koundinya Veluri (kouvel)
approved these changes
Sep 27, 2023
Mike McLaughlin (mikem8361)
pushed a commit
to dotnet/diagnostics
that referenced
this pull request
Sep 30, 2023
…nd when using the Windows thread pool (#4160) Uses the properties exposed in microsoft/clrmd#1175 to show relevant Windows thread pool information if it's enabled --------- Co-authored-by: Mike McLaughlin <mikem@microsoft.com>
Lee Culver (leculver)
pushed a commit
to leculver/diagnostics
that referenced
this pull request
Feb 19, 2026
…nd when using the Windows thread pool (dotnet#4160) Uses the properties exposed in microsoft/clrmd#1175 to show relevant Windows thread pool information if it's enabled --------- Co-authored-by: Mike McLaughlin <mikem@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.