Skip to content

Enabling Vgem driver in kernel - #3227

Merged
Max Brodeur-Urbas (MaxBrodeurUrbas) merged 1 commit into
mainfrom
maxbr/main/vgem_driver
Jun 24, 2022
Merged

Max Brodeur-Urbas (MaxBrodeurUrbas) merged 1 commit into
mainfrom
maxbr/main/vgem_driver

Conversation

@MaxBrodeurUrbas

@MaxBrodeurUrbas Max Brodeur-Urbas (MaxBrodeurUrbas) commented Jun 23, 2022 •

Copy link
Copy Markdown
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Change Log
  • Enabling Vgem driver in x86
Does this affect the toolchain?

YES

Associated issues
  • Task #39515182
Test Methodology
  • Pipeline build id: 205910 and tested pipeline image.

@ghost ghost added the main PR Destined for main label Jun 23, 2022

@rlmenge Rachel Menge (rlmenge) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just would like to confirm that we should not turn this on in aarch64 as well

@MaxBrodeurUrbas

Copy link
Copy Markdown
Author

LGTM. Just would like to confirm that we should not turn this on in aarch64 as well

its already on there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants